bench: Fix thread sanitizer issue in AssembleBlock benchmark #14083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
maflcko
force-pushed
the
Mf1808-benchAssembleBlockThread
branch
3 times, most recently
from
faed9ae
to
faf10c6
Compare
maflcko
force-pushed
the
Mf1808-benchAssembleBlockThread
branch
from
faf10c6
to
fa7435d
Compare
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
@MarcoFalke Why the close? Fixed elsewhere? |
|
@practicalswift I can't reproduce this anymore, so maybe not worth spending time on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By destructing the blocks early in the loop, we could no longer read the hash of the first transaction (the only thing we are interested in).
So just keep all blocks fully in memory for the whole benchmark.