changed request payment button text and tab description #14484

HatboyWonder · 2018-10-15T09:49:50Z

Small change by altering the text values for the request payment button and it's tab description to the ones suggested in #14482.

Closes #14482

jonasschnelli · 2018-10-15T10:37:10Z

utACK 59a9bd6.
Though we should probably discuss how we could remove the address book and eventually increase the usability of per-transaction comments and labels.

meshcollider · 2018-10-15T10:53:58Z

utACK 59a9bd6

@jonasschnelli agreed, this is a good first step for usability though

HatboyWonder · 2018-10-15T12:07:29Z

I can surely help with improving per-transaction comments and labels if you point me in the right direction.

luke-jr · 2018-10-15T12:10:47Z

src/qt/forms/receivecoinsdialog.ui

@@ -108,7 +108,7 @@
             </size>
            </property>
            <property name="text">
-             <string>&amp;Request payment</string>
+             <string>&amp;Receive payment</string>


This doesn't seem literally correct. Receiving only happens when the sender sends. :/

Should this text even change than. As far as I understand it's function it makes sense.

maybe call it something like "Create new receiving address" instead? (I guess "request payment" was also not literally correct, since it doesn't send a payment request anywhere AFAICT)

src/qt/addressbookpage.cpp

luke-jr · 2018-10-15T12:46:40Z

src/qt/addressbookpage.cpp

@@ -107,7 +107,7 @@ AddressBookPage::AddressBookPage(const PlatformStyle *platformStyle, Mode _mode,
        ui->newAddress->setVisible(true);
        break;
    case ReceivingTab:
-        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. Use the request payment button in the receive tab to create new addresses."));
+        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. Use the 'Create new receiving address' button in the receive tab to create new addresses."));


Nit: Prefer to have the button label here as a %1 token, so translations don't need to change when/if we rename the button again. (OTOH, the button itself needs &, so maybe not worth the trouble...)

luke-jr · 2018-10-15T12:47:09Z

src/qt/forms/receivecoinsdialog.ui

@@ -108,7 +108,7 @@
             </size>
            </property>
            <property name="text">
-             <string>&amp;Receive payment</string>
+             <string>&amp;Create new receiving address</string>


Please keep r as the accelerator key.

promag · 2018-10-15T12:59:33Z

I think we shouldn't rush as this doesn't look consistent:

I agree with @jonasschnelli, first discuss, mock etc, and them implement?

HatboyWonder · 2018-10-16T05:34:42Z

I think we shouldn't rush as this doesn't look consistent:

I agree with @jonasschnelli, first discuss, mock etc, and them implement?

Ok so what is the scope of these changes. Should this be done in the course of this issue?

laanwj · 2019-01-16T17:30:31Z

This seems to have bled out a bit.

jonasschnelli · 2019-04-16T08:00:11Z

I think this is a general improvement. We can do further extensions/cleanup later. Lets merge this.
utACK c46a603
@HatboyWonder: can you squash the second commits since its basically overwriting your first commit.

fanquake · 2019-04-16T13:14:38Z

@jonasschnelli squashed/rebased in #15829.

…escription 81b2830 qt: update request payment button text and tab description (Tobias Kaderle) Pull request description: Rebased and squashed version of bitcoin#14484. ![create new address](https://user-images.githubusercontent.com/863730/56212202-1f665980-608c-11e9-80d8-87a6211a9def.png) ![addresses dialog](https://user-images.githubusercontent.com/863730/56212205-22614a00-608c-11e9-83e4-efe531ea6070.png) ACKs for commit 81b283: MarcoFalke: utACK 81b2830 jonasschnelli: utACK 81b2830 meshcollider: utACK bitcoin@81b2830 Tree-SHA512: 73297a098824e9c4f25a93cf0225f4597e9aa678cb0a2ded79613cc36e4c6e71b648d45a86bcf66324b4fd52fda9c9fa3c15e7523f26f4b8ebd09d97fceef7ed

81b2830 qt: update request payment button text and tab description (Tobias Kaderle) Pull request description: Rebased and squashed version of #14484. ![create new address](https://user-images.githubusercontent.com/863730/56212202-1f665980-608c-11e9-80d8-87a6211a9def.png) ![addresses dialog](https://user-images.githubusercontent.com/863730/56212205-22614a00-608c-11e9-83e4-efe531ea6070.png) ACKs for commit 81b283: MarcoFalke: utACK 81b2830 jonasschnelli: utACK 81b2830 meshcollider: utACK 81b2830 Tree-SHA512: 96c6dc1f08560066110ec916b0a8879265db46174a5c5993332509b6bceb93ed6a8e06e3e8bd382e35aacc1c4d4a2458ec1d065213060db34ded4f0b2683964a

…escription 81b2830 qt: update request payment button text and tab description (Tobias Kaderle) Pull request description: Rebased and squashed version of bitcoin#14484. ![create new address](https://user-images.githubusercontent.com/863730/56212202-1f665980-608c-11e9-80d8-87a6211a9def.png) ![addresses dialog](https://user-images.githubusercontent.com/863730/56212205-22614a00-608c-11e9-83e4-efe531ea6070.png) ACKs for commit 81b283: MarcoFalke: utACK 81b2830 jonasschnelli: utACK 81b2830 meshcollider: utACK bitcoin@81b2830 Tree-SHA512: 96c6dc1f08560066110ec916b0a8879265db46174a5c5993332509b6bceb93ed6a8e06e3e8bd382e35aacc1c4d4a2458ec1d065213060db34ded4f0b2683964a

changed request payment button text and tab description

59a9bd6

fanquake added the GUI label Oct 15, 2018

luke-jr suggested changes Oct 15, 2018

View reviewed changes

changed text from github comments

c46a603

luke-jr reviewed Oct 15, 2018

View reviewed changes

fanquake mentioned this pull request Apr 16, 2019

qt: update request payment button text and tab description #15829

Merged

fanquake closed this Apr 16, 2019

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changed request payment button text and tab description #14484

changed request payment button text and tab description #14484

HatboyWonder commented Oct 15, 2018 •

edited by meshcollider

jonasschnelli commented Oct 15, 2018

meshcollider commented Oct 15, 2018

HatboyWonder commented Oct 15, 2018

luke-jr Oct 15, 2018

HatboyWonder Oct 15, 2018

flack Oct 15, 2018 •

edited

HatboyWonder Oct 15, 2018

luke-jr Oct 15, 2018

luke-jr Oct 15, 2018

promag commented Oct 15, 2018

HatboyWonder commented Oct 16, 2018 •

edited

laanwj commented Jan 16, 2019

jonasschnelli commented Apr 16, 2019

fanquake commented Apr 16, 2019

changed request payment button text and tab description #14484

changed request payment button text and tab description #14484

Conversation

HatboyWonder commented Oct 15, 2018 • edited by meshcollider

jonasschnelli commented Oct 15, 2018

meshcollider commented Oct 15, 2018

HatboyWonder commented Oct 15, 2018

luke-jr Oct 15, 2018

Choose a reason for hiding this comment

HatboyWonder Oct 15, 2018

Choose a reason for hiding this comment

flack Oct 15, 2018 • edited

Choose a reason for hiding this comment

HatboyWonder Oct 15, 2018

Choose a reason for hiding this comment

luke-jr Oct 15, 2018

Choose a reason for hiding this comment

luke-jr Oct 15, 2018

Choose a reason for hiding this comment

promag commented Oct 15, 2018

HatboyWonder commented Oct 16, 2018 • edited

laanwj commented Jan 16, 2019

jonasschnelli commented Apr 16, 2019

fanquake commented Apr 16, 2019

HatboyWonder commented Oct 15, 2018 •

edited by meshcollider

flack Oct 15, 2018 •

edited

HatboyWonder commented Oct 16, 2018 •

edited