Skip to content

changed request payment button text and tab description #14484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HatboyWonder wants to merge 2 commits into from
Closed

changed request payment button text and tab description #14484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a9bd6
changed request payment button text and tab description
HatboyWonder Oct 15, 2018
c46a603
changed text from github comments
HatboyWonder Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/qt/addressbookpage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ AddressBookPage::AddressBookPage(const PlatformStyle *platformStyle, Mode _mode,
ui->newAddress->setVisible(true);
break;
case ReceivingTab:
ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. It is recommended to use a new receiving address for each transaction."));
ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. Use the 'Create new receiving address' button in the receive tab to create new addresses."));
Copy link
Copy Markdown
Member

@luke-jr luke-jr Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Prefer to have the button label here as a %1 token, so translations don't need to change when/if we rename the button again. (OTOH, the button itself needs &, so maybe not worth the trouble...)

ui->deleteAddress->setVisible(false);
ui->newAddress->setVisible(false);
break;
Expand Down
2 changes: 1 addition & 1 deletion src/qt/forms/receivecoinsdialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
</size>
</property>
<property name="text">
<string>&amp;Request payment</string>
<string>&amp;Create new receiving address</string>
Copy link
Copy Markdown
Member

@luke-jr luke-jr Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep r as the accelerator key.

</property>
<property name="icon">
<iconset resource="../bitcoin.qrc">
Expand Down