Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Run thread sanitizer on unit tests #14764

Merged
merged 3 commits into from Nov 23, 2018

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 19, 2018

On unit tests only for now. Disabled for the gui unit tests and all functional tests.

@MarcoFalke MarcoFalke changed the title travis: Run thread sanitizer [WIP] travis: Run thread sanitizer Nov 19, 2018
@sipa
Copy link
Member

@sipa sipa commented Nov 19, 2018

@MarcoFalke MarcoFalke force-pushed the Mf1811-travisSanThread branch 3 times, most recently from a3b0175 to 0611ce8 Nov 19, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Nov 20, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 20, 2018

Strong concept ACK

We really should test under all sanitizers in Travis – thanks for taking a step in that direction! :-)

@MarcoFalke MarcoFalke force-pushed the Mf1811-travisSanThread branch 11 times, most recently from a15a296 to faa37bf Nov 20, 2018
@MarcoFalke MarcoFalke changed the title [WIP] travis: Run thread sanitizer travis: Run thread sanitizer on unit tests Nov 20, 2018
@MarcoFalke MarcoFalke force-pushed the Mf1811-travisSanThread branch 3 times, most recently from aa1484f to 453efef Nov 20, 2018
@MarcoFalke MarcoFalke requested a review from practicalswift Nov 20, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Nov 21, 2018

utACK

Copy link
Contributor

@practicalswift practicalswift left a comment

Excellent work @MarcoFalke!

utACK modulo suggested changes

Would be really nice to also have the functional tests running under TSan :-)

.travis.yml Outdated Show resolved Hide resolved
.travis/test_03_before_install.sh Outdated Show resolved Hide resolved
.travis/test_04_install.sh Outdated Show resolved Hide resolved
@MarcoFalke MarcoFalke force-pushed the Mf1811-travisSanThread branch from 453efef to fa36d4e Nov 22, 2018
@MarcoFalke MarcoFalke merged commit fa7d36b into bitcoin:master Nov 23, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Nov 23, 2018
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke)
fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke)
89bf196 travis: Run thread sanitizer (MarcoFalke)

Pull request description:

  On unit tests only for now. Disabled for the gui unit tests and all functional tests.

Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
@MarcoFalke MarcoFalke deleted the Mf1811-travisSanThread branch Nov 23, 2018
MarcoFalke added a commit that referenced this issue Dec 18, 2018
…(TSan) build job

eaf4070 Add suppression for InterruptRPC (fRPCRunning) data race (practicalswift)
5e5138a travis: Use trap and set -e errtrace (Chun Kuan Lee)
069752b build: Enable functional tests in the ThreadSanitizer (TSan) build job (practicalswift)

Pull request description:

  Enable functional tests in the ThreadSanitizer (TSan) build job.

  This is a follow-up to @MarcoFalke's #14764 which added TSan but for unit tests only.

Tree-SHA512: dcc24d311fa124772c3036b16c2bf94732ece36c3e22b4bb8fe941772e52157ab2b1a90b1880b81079c2eef2d344ca7e1da58324b75dbf82d16204d591ad49fb
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Aug 16, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke)
fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke)
89bf196 travis: Run thread sanitizer (MarcoFalke)

Pull request description:

  On unit tests only for now. Disabled for the gui unit tests and all functional tests.

Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Aug 16, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke)
fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke)
89bf196 travis: Run thread sanitizer (MarcoFalke)

Pull request description:

  On unit tests only for now. Disabled for the gui unit tests and all functional tests.

Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Aug 17, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke)
fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke)
89bf196 travis: Run thread sanitizer (MarcoFalke)

Pull request description:

  On unit tests only for now. Disabled for the gui unit tests and all functional tests.

Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Aug 18, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke)
fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke)
89bf196 travis: Run thread sanitizer (MarcoFalke)

Pull request description:

  On unit tests only for now. Disabled for the gui unit tests and all functional tests.

Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants