travis: Run thread sanitizer on unit tests #14764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
|
This looks related: https://groups.google.com/forum/#!topic/thread-sanitizer/nmhRglhlohI |
maflcko
force-pushed
the
Mf1811-travisSanThread
branch
3 times, most recently
from
a3b0175
to
0611ce8
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Strong concept ACK We really should test under all sanitizers in Travis – thanks for taking a step in that direction! :-) |
maflcko
force-pushed
the
Mf1811-travisSanThread
branch
11 times, most recently
from
a15a296
to
faa37bf
Compare
maflcko
changed the title
maflcko
force-pushed
the
Mf1811-travisSanThread
branch
3 times, most recently
from
aa1484f
to
453efef
Compare
|
utACK |
practicalswift
suggested changes
Nov 21, 2018
There was a problem hiding this comment.
Excellent work @MarcoFalke!
utACK modulo suggested changes
Would be really nice to also have the functional tests running under TSan :-)
maflcko
force-pushed
the
Mf1811-travisSanThread
branch
from
453efef
to
fa36d4e
Compare
maflcko
pushed a commit
that referenced
this pull request
Nov 23, 2018
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke) fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke) 89bf196 travis: Run thread sanitizer (MarcoFalke) Pull request description: On unit tests only for now. Disabled for the gui unit tests and all functional tests. Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
maflcko
pushed a commit
that referenced
this pull request
Dec 18, 2018
…(TSan) build job eaf4070 Add suppression for InterruptRPC (fRPCRunning) data race (practicalswift) 5e5138a travis: Use trap and set -e errtrace (Chun Kuan Lee) 069752b build: Enable functional tests in the ThreadSanitizer (TSan) build job (practicalswift) Pull request description: Enable functional tests in the ThreadSanitizer (TSan) build job. This is a follow-up to @MarcoFalke's #14764 which added TSan but for unit tests only. Tree-SHA512: dcc24d311fa124772c3036b16c2bf94732ece36c3e22b4bb8fe941772e52157ab2b1a90b1880b81079c2eef2d344ca7e1da58324b75dbf82d16204d591ad49fb
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 16, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke) fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke) 89bf196 travis: Run thread sanitizer (MarcoFalke) Pull request description: On unit tests only for now. Disabled for the gui unit tests and all functional tests. Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 16, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke) fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke) 89bf196 travis: Run thread sanitizer (MarcoFalke) Pull request description: On unit tests only for now. Disabled for the gui unit tests and all functional tests. Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 17, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke) fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke) 89bf196 travis: Run thread sanitizer (MarcoFalke) Pull request description: On unit tests only for now. Disabled for the gui unit tests and all functional tests. Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 18, 2021
fa7d36b test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke) fa36d4e travis: --disable-hardening for xenial thread sanitizer (MarcoFalke) 89bf196 travis: Run thread sanitizer (MarcoFalke) Pull request description: On unit tests only for now. Disabled for the gui unit tests and all functional tests. Tree-SHA512: 56f7d3b44e7cb68c76a2dc5abd85658955b1c2188932e988667c5a1cbcdd6be995d37bb949d62c6eb08a4aebfc43ff0370b7da1719d4e4f322a3495c1941a5e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On unit tests only for now. Disabled for the gui unit tests and all functional tests.