Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: Remove hidden columns in coin control dialog #14828

Merged
merged 1 commit into from Dec 4, 2018
Merged

qt: Remove hidden columns in coin control dialog #14828

merged 1 commit into from Dec 4, 2018

Conversation

promag
Copy link
Member

@promag promag commented Nov 28, 2018 •
edited

Instead of having hidden columns, store the data in specific roles.

Overlaps with #14817, fixes #11811.

@promag
Copy link
Member Author

promag commented Nov 28, 2018

Ah @laanwj already suggested this approach in #11811 (comment)

@fanquake fanquake added the GUI label Nov 28, 2018
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto
Copy link
Member

hebasto commented Nov 28, 2018

Concept ACK.

@hebasto hebasto mentioned this pull request Nov 28, 2018
Closed
@hebasto
Copy link
Member

hebasto commented Nov 28, 2018

There are some concerns about 4cd9a3a772807df825c27c410410c3ea96b59371 commit.

QTreeView::uniformRowHeights:

This property should only be set to true if it is guaranteed that all items in the view has the same height. This enables the view to do some optimizations.

  1. IMO, it is not a good idea to mix a bugfix commit with an optimization commit in one PR (see Pull Request Philosophy).
  2. There is no obvious need for such optimization.
  3. How can 'the same height' condition be guaranteed now and then?
  4. How can I test this optimization and measure the effect of it?

Could this optimization commit be moved out of this PR's scope?

@promag
Copy link
Member Author

promag commented Nov 28, 2018

@hebasto removed commit.

hebasto
hebasto requested changes Nov 29, 2018
View reviewed changes
src/qt/coincontroldialog.cpp Outdated Show resolved Hide resolved
@hebasto
Copy link
Member

hebasto commented Nov 29, 2018

tACK 06cc0412da8fc3d031e804e7df0ae5b9686663b0 after nit

@laanwj
Copy link
Member

laanwj commented Nov 29, 2018

Ah @laanwj already suggested this approach in #11811 (comment)

Yes, using column metadata is definitely the more idiomatic approach, thanks for doing this.

utACK 1c28feb

@hebasto
Copy link
Member

hebasto commented Nov 29, 2018

re- tACK 1c28feb

@jonasschnelli
Copy link
Contributor

Tested ACK 1c28feb

@jonasschnelli jonasschnelli merged commit 1c28feb into bitcoin:master Dec 4, 2018
jonasschnelli added a commit that referenced this pull request Dec 4, 2018
@jonasschnelli
Merge #14828: qt: Remove hidden columns in coin control dialog
64fc7c0 
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with #14817, fixes #11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Sep 13, 2020
@jonasschnelli @UdjinM6
Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog
9f02792 
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with bitcoin#14817, fixes bitcoin#11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Sep 16, 2020
@jonasschnelli @xdustinface
Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog
b7bbbd1 
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with bitcoin#14817, fixes bitcoin#11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Sep 16, 2020
@jonasschnelli @xdustinface
Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog
c76a737 
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with bitcoin#14817, fixes bitcoin#11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 23, 2020
@xdustinface @jonasschnelli @UdjinM6
qt: Finetune CoinControlDialog + bitcoin#14828 (#3701)
b10dc1f 
* qt: Add min-height for CoinControlTreeWidget#treeWidget::item

The rows resize without it if they get locked and the lock icon appears 
besides the checkbox. Looks weird.. and especially if you press the lock 
all button its just not nice.

* qt: Set background transparency for CoinControl item::hover

* Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog

1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with bitcoin#14817, fixes bitcoin#11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422

* qt: Add border-bottom for tree items in CoinControl

* qt: Stretch address column in CoinControlDialog

* Adjust column width for a couple of columns

* qt: Hide PrivateSend rounds column for normal Send tab's CoinControl

* qt: Hide unrelated coins in CoinControl based on active mode. Still allow to show them.

* qt: Hide empty top level items in CoinControlDialog's tree mode

* qt: Hide tree/list radio buttons and default to list for PrivateSend

* qt: Hide address/label column in CoinControl for PrivateSend

* qt: Remove obsolete empty columns

* qt: Rename column "PS Rounds" to "Mixing Rounds"

* qt: Move border-bottom in already existing css selector

* Reveal all PS related coins in coincontrol while in PS mode, not only ones with rounds>=1

Also tweak button text

* qt: Only moving a statement a bit

* qt: Hide the "hideButton" in CoinControlDialog if PrivatSend is disabled

And make it default to show all coins in that case..

Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 24, 2020
@xdustinface @jonasschnelli
@UdjinM6 @PastaPastaPasta
qt: Finetune CoinControlDialog + bitcoin#14828 (dashpay#3701)
f4e3bf9 
* qt: Add min-height for CoinControlTreeWidget#treeWidget::item

The rows resize without it if they get locked and the lock icon appears
besides the checkbox. Looks weird.. and especially if you press the lock
all button its just not nice.

* qt: Set background transparency for CoinControl item::hover

* Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog

1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with bitcoin#14817, fixes bitcoin#11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422

* qt: Add border-bottom for tree items in CoinControl

* qt: Stretch address column in CoinControlDialog

* Adjust column width for a couple of columns

* qt: Hide PrivateSend rounds column for normal Send tab's CoinControl

* qt: Hide unrelated coins in CoinControl based on active mode. Still allow to show them.

* qt: Hide empty top level items in CoinControlDialog's tree mode

* qt: Hide tree/list radio buttons and default to list for PrivateSend

* qt: Hide address/label column in CoinControl for PrivateSend

* qt: Remove obsolete empty columns

* qt: Rename column "PS Rounds" to "Mixing Rounds"

* qt: Move border-bottom in already existing css selector

* Reveal all PS related coins in coincontrol while in PS mode, not only ones with rounds>=1

Also tweak button text

* qt: Only moving a statement a bit

* qt: Hide the "hideButton" in CoinControlDialog if PrivatSend is disabled

And make it default to show all coins in that case..

Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 8, 2020
@promag @PiRK
qt: Remove hidden columns in coin control dialog
75362b2 
Summary:
Store the data in specific roles instead of storing it as text in hidden columns.

Backport of Core [[ bitcoin/bitcoin#14828 | PR14828 ]]

Test Plan:
`ninja && ninja check`

Run `src/qt/bitcoin-qt` and verify that the empty columns at the end of the table are no longer there, in the Coin Selection dialog.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7798
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto requested changes

Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitcoin-Qt Coin Selection window has unnecessary columns "9" and "10"
6 participants
@promag @DrahtBot @hebasto @laanwj @jonasschnelli @fanquake