-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitcoin-Qt Coin Selection window has unnecessary columns "9" and "10" #11811
Comments
In theory they are meant to be hidden. bitcoin/src/qt/coincontroldialog.cpp Lines 131 to 138 in 3c098a8
|
It's probably because the PPA is built with an older version then Qt5.7 which we use in depends. Could even be a Qt4 version. |
The PPA one is linked against |
We (still) cant move off of Qt4 because of #9038. Still waiting on the death of the tray icon... |
FWIW it shouldn't be necessary to use columns to store extra per-row information, from what I remember there are other ways to store extra information in the model backing the tree widget, though I don't remember immediately how.
The death of ubuntu unity is probably sooner. I'm almost certain no other desktop environment has this problem. |
Is this still an issue? |
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with #14817, fixes #11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with bitcoin#14817, fixes bitcoin#11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with bitcoin#14817, fixes bitcoin#11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with bitcoin#14817, fixes bitcoin#11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422
* qt: Add min-height for CoinControlTreeWidget#treeWidget::item The rows resize without it if they get locked and the lock icon appears besides the checkbox. Looks weird.. and especially if you press the lock all button its just not nice. * qt: Set background transparency for CoinControl item::hover * Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog 1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with bitcoin#14817, fixes bitcoin#11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422 * qt: Add border-bottom for tree items in CoinControl * qt: Stretch address column in CoinControlDialog * Adjust column width for a couple of columns * qt: Hide PrivateSend rounds column for normal Send tab's CoinControl * qt: Hide unrelated coins in CoinControl based on active mode. Still allow to show them. * qt: Hide empty top level items in CoinControlDialog's tree mode * qt: Hide tree/list radio buttons and default to list for PrivateSend * qt: Hide address/label column in CoinControl for PrivateSend * qt: Remove obsolete empty columns * qt: Rename column "PS Rounds" to "Mixing Rounds" * qt: Move border-bottom in already existing css selector * Reveal all PS related coins in coincontrol while in PS mode, not only ones with rounds>=1 Also tweak button text * qt: Only moving a statement a bit * qt: Hide the "hideButton" in CoinControlDialog if PrivatSend is disabled And make it default to show all coins in that case.. Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
* qt: Add min-height for CoinControlTreeWidget#treeWidget::item The rows resize without it if they get locked and the lock icon appears besides the checkbox. Looks weird.. and especially if you press the lock all button its just not nice. * qt: Set background transparency for CoinControl item::hover * Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog 1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with bitcoin#14817, fixes bitcoin#11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422 * qt: Add border-bottom for tree items in CoinControl * qt: Stretch address column in CoinControlDialog * Adjust column width for a couple of columns * qt: Hide PrivateSend rounds column for normal Send tab's CoinControl * qt: Hide unrelated coins in CoinControl based on active mode. Still allow to show them. * qt: Hide empty top level items in CoinControlDialog's tree mode * qt: Hide tree/list radio buttons and default to list for PrivateSend * qt: Hide address/label column in CoinControl for PrivateSend * qt: Remove obsolete empty columns * qt: Rename column "PS Rounds" to "Mixing Rounds" * qt: Move border-bottom in already existing css selector * Reveal all PS related coins in coincontrol while in PS mode, not only ones with rounds>=1 Also tweak button text * qt: Only moving a statement a bit * qt: Hide the "hideButton" in CoinControlDialog if PrivatSend is disabled And make it default to show all coins in that case.. Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
* qt: Add min-height for CoinControlTreeWidget#treeWidget::item The rows resize without it if they get locked and the lock icon appears besides the checkbox. Looks weird.. and especially if you press the lock all button its just not nice. * qt: Set background transparency for CoinControl item::hover * Merge bitcoin#14828: qt: Remove hidden columns in coin control dialog 1c28feb qt: Remove hidden columns in coin control dialog (João Barbosa) Pull request description: Instead of having hidden columns, store the data in specific roles. Overlaps with bitcoin#14817, fixes bitcoin#11811. Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422 * qt: Add border-bottom for tree items in CoinControl * qt: Stretch address column in CoinControlDialog * Adjust column width for a couple of columns * qt: Hide PrivateSend rounds column for normal Send tab's CoinControl * qt: Hide unrelated coins in CoinControl based on active mode. Still allow to show them. * qt: Hide empty top level items in CoinControlDialog's tree mode * qt: Hide tree/list radio buttons and default to list for PrivateSend * qt: Hide address/label column in CoinControl for PrivateSend * qt: Remove obsolete empty columns * qt: Rename column "PS Rounds" to "Mixing Rounds" * qt: Move border-bottom in already existing css selector * Reveal all PS related coins in coincontrol while in PS mode, not only ones with rounds>=1 Also tweak button text * qt: Only moving a statement a bit * qt: Hide the "hideButton" in CoinControlDialog if PrivatSend is disabled And make it default to show all coins in that case.. Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Maybe they have some purpose, but it isn't immediately obvious. I tried Tree & List mode, they're never populated.
Note: I just noticed I'm not seeing this on Ubuntu 17.10 x64 with 0.15.1 downloaded from bitcoincore.org.
The text was updated successfully, but these errors were encountered: