Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes. #15201
changed the title
net: Add missing cs_vNodes lock in CConnman::Stop(). Add missing locking annotation.
Jan 18, 2019
Thanks! I am still somewhat skeptical about adding a lock annotation then working around it, but all in all I think the annotation has value because it still allows checking the other uses of the lock. It's also good to document the hairy situation with a comment.
Feb 8, 2019
Adding the to-be-fixed data race for future reference:
Line numbers as of bb68abe