New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: Script validation flags #15399
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Copyright (c) 2009-2019 The Bitcoin Core developers | ||
| // Distributed under the MIT software license, see the accompanying | ||
| // file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| #include <script/interpreter.h> | ||
| #include <script/script.h> | ||
| #include <streams.h> | ||
| #include <version.h> | ||
|
|
||
| #include <test/fuzz/fuzz.h> | ||
|
|
||
| /** Flags that are not forbidden by an assert */ | ||
| static bool IsValidFlagCombination(unsigned flags); | ||
|
|
||
| void test_one_input(std::vector<uint8_t> buffer) | ||
| { | ||
| CDataStream ds(buffer, SER_NETWORK, INIT_PROTO_VERSION); | ||
| try { | ||
| int nVersion; | ||
| ds >> nVersion; | ||
| ds.SetVersion(nVersion); | ||
| } catch (const std::ios_base::failure&) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| const CTransaction tx(deserialize, ds); | ||
| const PrecomputedTransactionData txdata(tx); | ||
|
|
||
| unsigned int verify_flags; | ||
| ds >> verify_flags; | ||
|
|
||
| if (!IsValidFlagCombination(verify_flags)) return; | ||
|
|
||
| unsigned int fuzzed_flags; | ||
| ds >> fuzzed_flags; | ||
|
|
||
| for (unsigned i = 0; i < tx.vin.size(); ++i) { | ||
| CTxOut prevout; | ||
| ds >> prevout; | ||
|
|
||
| const TransactionSignatureChecker checker{&tx, i, prevout.nValue, txdata}; | ||
|
|
||
| ScriptError serror; | ||
| const bool ret = VerifyScript(tx.vin.at(i).scriptSig, prevout.scriptPubKey, &tx.vin.at(i).scriptWitness, verify_flags, checker, &serror); | ||
| assert(ret == (serror == SCRIPT_ERR_OK)); | ||
|
|
||
| // Verify that removing flags from a passing test or adding flags to a failing test does not change the result | ||
| if (ret) { | ||
| verify_flags &= ~fuzzed_flags; | ||
| } else { | ||
| verify_flags |= fuzzed_flags; | ||
| } | ||
| if (!IsValidFlagCombination(verify_flags)) return; | ||
|
|
||
| ScriptError serror_fuzzed; | ||
| const bool ret_fuzzed = VerifyScript(tx.vin.at(i).scriptSig, prevout.scriptPubKey, &tx.vin.at(i).scriptWitness, verify_flags, checker, &serror_fuzzed); | ||
| assert(ret_fuzzed == (serror_fuzzed == SCRIPT_ERR_OK)); | ||
|
|
||
| assert(ret_fuzzed == ret); | ||
| } | ||
| } catch (const std::ios_base::failure&) { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| static bool IsValidFlagCombination(unsigned flags) | ||
| { | ||
| if (flags & SCRIPT_VERIFY_CLEANSTACK && ~flags & (SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS)) return false; | ||
| if (flags & SCRIPT_VERIFY_WITNESS && ~flags & SCRIPT_VERIFY_P2SH) return false; | ||
| return true; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dropped
inthere intentional? Same result but looks non-idiomatic :-)