Suggested interfaces::Chain cleanups from #15288 #15531
Conversation
Mostly documentation improvements requested in the last review of bitcoin#15288 before it was merged (bitcoin#15288 (review))
|
ACK de9f7f2 |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Updated de9f7f2 -> 4d4e4c6 (pr/wclean2.1 -> pr/wclean2.2, compare) with suggested changes |
|
re-utACK 4d4e4c6 |
| //! the future) ability to access to the chain state, receive notifications, | ||
| //! estimate fees, and submit transactions. | ||
| //! | ||
| //! TODO: Current chain methods are too low level, exposing too much of the |
There was a problem hiding this comment.
nit: I suspect this and below won't be particularly helpful if included in the doxygen output
There was a problem hiding this comment.
I think it is helpful to describe the long term goal better (and give ideas to work on for new contributors)
There was a problem hiding this comment.
re: #15531 (comment)
nit: I suspect this and below won't be particularly helpful if included in the doxygen output
I don't know if this is a formatting suggestion or a content suggestion. It would help if you could be more specific. I've seen links posted to bitcoin doxygen output once in a while, but I've haven't used the doxygen output myself. I do read comments that appear in code. And I especially like comments that tell me why a particular piece of code was designed a certain way, so I am not left in the dark about things that seem like counterintuitive decision designs.
|
re-utACK 4d4e4c6 |
4d4e4c6 Suggested interfaces::Chain cleanups from #15288 (Russell Yanofsky) Pull request description: Mostly documentation improvements requested in the last review of #15288 before it was merged (#15288 (review)) Tree-SHA512: 64e912520bbec20a44032f265a8cf3f11ad7f5126c8626b5ad5e888227b1f92ecb321522fab4bbbd613230b55450abd6ace023631d0a4f357a780d65c5638bfe
…rom #15288 Summary: 4d4e4c6448 Suggested interfaces::Chain cleanups from #15288 (Russell Yanofsky) Pull request description: Mostly documentation improvements requested in the last review of #15288 before it was merged (bitcoin/bitcoin#15288 (review)) Tree-SHA512: 64e912520bbec20a44032f265a8cf3f11ad7f5126c8626b5ad5e888227b1f92ecb321522fab4bbbd613230b55450abd6ace023631d0a4f357a780d65c5638bfe --- Depends on D5869 This is a backport of Core [[bitcoin/bitcoin#15531 | PR15531]] Test Plan: cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5870
…n#15288 4d4e4c6 Suggested interfaces::Chain cleanups from bitcoin#15288 (Russell Yanofsky) Pull request description: Mostly documentation improvements requested in the last review of bitcoin#15288 before it was merged (bitcoin#15288 (review)) Tree-SHA512: 64e912520bbec20a44032f265a8cf3f11ad7f5126c8626b5ad5e888227b1f92ecb321522fab4bbbd613230b55450abd6ace023631d0a4f357a780d65c5638bfe
…n#15288 4d4e4c6 Suggested interfaces::Chain cleanups from bitcoin#15288 (Russell Yanofsky) Pull request description: Mostly documentation improvements requested in the last review of bitcoin#15288 before it was merged (bitcoin#15288 (review)) Tree-SHA512: 64e912520bbec20a44032f265a8cf3f11ad7f5126c8626b5ad5e888227b1f92ecb321522fab4bbbd613230b55450abd6ace023631d0a4f357a780d65c5638bfe
Mostly documentation improvements requested in the last review of #15288 before it was merged (#15288 (review))