refactor: Expose UndoReadFromDisk in header #15623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesob
approved these changes
Mar 19, 2019
|
utACK faad977 |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jimpo
reviewed
Mar 19, 2019
src/validation.cpp
Outdated
| @@ -1515,6 +1513,8 @@ static bool UndoReadFromDisk(CBlockUndo& blockundo, const CBlockIndex *pindex) | |||
| return true; | |||
| } | |||
|
|
|||
| namespace { | |||
There was a problem hiding this comment.
Is this anonymous namespace still necessary? The two methods inside it are both static.
maflcko
force-pushed
the
1903-UndoReadFromDiskHeader
branch
from
faad977
to
fa11c03
Compare
|
Removed |
|
re-utACK fa11c03 |
|
utACK fa11c03 |
1 similar comment
|
utACK fa11c03 |
|
utACK fa11c03 |
maflcko
pushed a commit
that referenced
this pull request
Mar 20, 2019
fa11c03 refactor: Expose UndoReadFromDisk in header (MarcoFalke) Pull request description: It is not possible to calculate the fee of a non-mempool transaction in RPCs unless txindex is active or the prevtxs are passed in through the RPC. Fix that issue for confirmed txs by exposing `UndoReadFromDisk` in the header file. This pull is a requirement for * rpc: faster getblockstats using BlockUndo data #14802 * Index for BIP 157 block filters #14121 * my local patches Tree-SHA512: 859ea5f2dfb4feac612b50faeb0e2b6c07b83f1d983e519d7647a78058d85c0390fd09ec66b460ae7a4c3b273e81b0013ee9f4bb8dfba0c4782ffaa1fa453ea6
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Sep 3, 2019
Github-Pull: bitcoin#15623 Rebased-From: fa11c03 (diff minimised)
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 1, 2020
Summary: bitcoin/bitcoin@fa11c03 --- Backport of Core [[bitcoin/bitcoin#15623 | PR15623]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6304
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: bitcoin/bitcoin@fa11c03 --- Backport of Core [[bitcoin/bitcoin#15623 | PR15623]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6304
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 2, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 8, 2021
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Aug 11, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 12, 2021
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Aug 13, 2021
merge bitcoin#15118, bitcoin#14172, bitcoin#15623, bitcoin#14121, partial bitcoin#13743, partial bitcoin#15280: block filters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to calculate the fee of a non-mempool transaction in RPCs unless txindex is active or the prevtxs are passed in through the RPC.
Fix that issue for confirmed txs by exposing
UndoReadFromDiskin the header file.This pull is a requirement for