qt, wallet: Revamp SendConfirmationDialog #15886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property-based API has been used. Added support for the `informativeText` and `detailedText` properties.
|
Nice work! |
|
Tested a bit. I think the "show details..." approach should only appear if we have multiple recipients. But I'm open to be convinced otherwise. |
|
@promag @jonasschnelli
Nice. Done. |
hebasto
force-pushed
the
20190424-send-confirmation-dialog
branch
from
65f3a7c
to
5d85328
Compare
hebasto
force-pushed
the
20190424-send-confirmation-dialog
branch
from
5d85328
to
78f9b51
Compare
|
code review ACK 78f9b51 |
laanwj
added a commit
that referenced
this pull request
Jun 6, 2019
78f9b51 Do not show list for the only recipient. (Hennadii Stepanov) 2ee756f Show recipient list as detailedText of QMessageBox (Hennadii Stepanov) 654e419 Make SendConfirmationDialog fully fledged (Hennadii Stepanov) Pull request description: Fix #15667 With this PR:   ACKs for commit 78f9b5: laanwj: code review ACK 78f9b51 Tree-SHA512: f868d78d01b0898aff2277fa3a7e8c6f936acbbcfa8a0323cddcd9daba4a998030c667bd803ae67c2b9179ed8082a48a67568e9ba3c8d14e3a2d88d93ada94fa
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 6, 2019
78f9b51 Do not show list for the only recipient. (Hennadii Stepanov) 2ee756f Show recipient list as detailedText of QMessageBox (Hennadii Stepanov) 654e419 Make SendConfirmationDialog fully fledged (Hennadii Stepanov) Pull request description: Fix bitcoin#15667 With this PR:   ACKs for commit 78f9b5: laanwj: code review ACK 78f9b51 Tree-SHA512: f868d78d01b0898aff2277fa3a7e8c6f936acbbcfa8a0323cddcd9daba4a998030c667bd803ae67c2b9179ed8082a48a67568e9ba3c8d14e3a2d88d93ada94fa
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: The property-based API has been used. Added support for the `informativeText` and `detailedText` properties. bitcoin/bitcoin@654e419 --- Partial backport of Core [[bitcoin/bitcoin#15886 | PR15886]] Test Plan: ninja run bitcoin-qt in regtest mode and check things out Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7289
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: bitcoin/bitcoin@2ee756f --- Depends on 7289 Partial backport of Core [[bitcoin/bitcoin#15886 | PR15886]] Test Plan: ninja send coins with bitcoin-qt -regtest and check it behaves as expected Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7290
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: bitcoin/bitcoin@78f9b51 --- Depends on D7290 Concludes backport of Core [[bitcoin/bitcoin#15886 | PR15886]] Test Plan: ninja send coins with bitcoin-qt -regtest and check there's no more detailed option for single recipient Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7291
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Oct 23, 2021
78f9b51 Do not show list for the only recipient. (Hennadii Stepanov) 2ee756f Show recipient list as detailedText of QMessageBox (Hennadii Stepanov) 654e419 Make SendConfirmationDialog fully fledged (Hennadii Stepanov) Pull request description: Fix bitcoin#15667 With this PR:   ACKs for commit 78f9b5: laanwj: code review ACK 78f9b51 Tree-SHA512: f868d78d01b0898aff2277fa3a7e8c6f936acbbcfa8a0323cddcd9daba4a998030c667bd803ae67c2b9179ed8082a48a67568e9ba3c8d14e3a2d88d93ada94fa
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Oct 26, 2021
78f9b51 Do not show list for the only recipient. (Hennadii Stepanov) 2ee756f Show recipient list as detailedText of QMessageBox (Hennadii Stepanov) 654e419 Make SendConfirmationDialog fully fledged (Hennadii Stepanov) Pull request description: Fix bitcoin#15667 With this PR:   ACKs for commit 78f9b5: laanwj: code review ACK 78f9b51 Tree-SHA512: f868d78d01b0898aff2277fa3a7e8c6f936acbbcfa8a0323cddcd9daba4a998030c667bd803ae67c2b9179ed8082a48a67568e9ba3c8d14e3a2d88d93ada94fa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15667
With this PR:
