wallet: log on rescan completion #15901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
approved these changes
Apr 26, 2019
| @@ -1862,6 +1862,8 @@ CWallet::ScanResult CWallet::ScanForWalletTransactions(const uint256& start_bloc | |||
| } else if (block_height && chain().shutdownRequested()) { | |||
| WalletLogPrintf("Rescan interrupted by shutdown request at block %d. Progress=%f\n", *block_height, progress_current); | |||
| result.status = ScanResult::USER_ABORT; | |||
| } else { | |||
| WalletLogPrintf("Rescan completed.\n"); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
style-nit: Could add a commit to remove this scope (and the 4 extraneous spaces that precede the lines)?
There was a problem hiding this comment.
I added the commit to do that, but the diff is pretty big.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Checked that the second commit is only removing a scope and whitespace. utACK 34e78fd Show signature |
|
Concept ACK |
|
nit: Looking at the callers, this one already logs the success: Line 4233 in 7034149 |
andrewtoth
force-pushed
the
log-rescan-completed
branch
from
34e78fd
to
fdc8755
Compare
andrewtoth
force-pushed
the
log-rescan-completed
branch
from
fdc8755
to
1b602f6
Compare
|
@Empact I removed the logging from that caller, and added the time check to the log for every caller. |
|
utACK 1b602f6 |
1 similar comment
|
utACK 1b602f6 |
meshcollider
added a commit
that referenced
this pull request
Apr 28, 2019
1b602f6 remove extraneous scope (andrewtoth) 6ad372a wallet: log on rescan completion (andrewtoth) Pull request description: Currently there is nothing logged when a rescan completes successfully. This leaves the last log message something like: ``` Still rescanning. At block 573037. Progress=0.998415 ``` It is unclear when the rescan actually finished. This adds a `Rescan completed.` message to make it more clear. ACKs for commit 1b602f: Empact: utACK 1b602f6 meshcollider: utACK 1b602f6 Tree-SHA512: 618d646a0f143c2372f1db91c14e7f677b39fb3a2957e887cbc349971c3e8953bc017e2028ac489368c20dbb9a7265c4c2d448c95de785366acfe0e576f1be66
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 8, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 8, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 12, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 13, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 13, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 13, 2021
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is nothing logged when a rescan completes successfully. This leaves the last log message something like:
It is unclear when the rescan actually finished. This adds a
Rescan completed.message to make it more clear.