util: Fix compilation errors in support/lockedpool.cpp

[jkczyz]

Changes in #12048 cause a compilation error in Arena::walk() when
ARENA_DEBUG is defined. Specifically, Arena's chunks_free map was
changed to have a different value type.

Additionally, missing includes cause other compilation errors when
ARENA_DEBUG is defined.

Reproduced with:

make CPPFLAGS=-DARENA_DEBUG

[Empact]

How about a test case?

[jkczyz]

@Empact Would it be sufficient to remove #ifdef ARENA_DEBUG from this code to ensure the compilation error is caught in the future? Not sure if this goes against conventions for debug code.

[Empact]

No, the guards are there for a reason, just would be nice to exercise the guarded code at some point so such a failure is caught in the future.

The guiding principle is: “test anything that might fail and everything that does”.

May not be practical, but one possibility is treating one of the Travis test runs with ARENA_DEBUG.

[jkczyz]

I defined ARENA_DEBUG for a couple environments. Wasn't sure which environments, so I just added it to ones that were already setting CPPFLAGS. The Travis CI build failures seem unrelated.

I had to update the Arena's test to use allocated memory to prevent a segfault. Figured this may have been needed as I observed it locally.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #17517 (ci: Bump to clang-8 for asan build to avoid segfaults on ppc64le by MarcoFalke)
• #16834 (Fetch Headers over DNS by TheBlueMatt)
• #16762 (Rust-based Backup over-REST block downloader by TheBlueMatt)
• #16195 (util: Use void* throughout support/lockedpool.h by jkczyz)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[laanwj]

Thanks for catching this and fixing the build with -DARENA_DEBUG, not 100% sure about the build system and test changes.

[DrahtBot]

Needs rebase

[fanquake]

Concept ACK. @jkczyz could you rebase this?

Compiling on macOS with ARENA_DEBUG:

  CXX      support/libbitcoin_util_a-lockedpool.o
support/lockedpool.cpp:141:10: error: no member named 'cout' in namespace 'std'
    std::cout <<
    ~~~~~^
support/lockedpool.cpp:142:22: error: no member named 'hex' in namespace 'std'
        "0x" << std::hex << std::setw(16) << std::setfill('0') << base <<
                ~~~~~^
support/lockedpool.cpp:142:34: error: no member named 'setw' in namespace 'std'
        "0x" << std::hex << std::setw(16) << std::setfill('0') << base <<
                            ~~~~~^
support/lockedpool.cpp:142:51: error: no member named 'setfill' in namespace 'std'
        "0x" << std::hex << std::setw(16) << std::setfill('0') << base <<
                                             ~~~~~^
support/lockedpool.cpp:143:23: error: no member named 'hex' in namespace 'std'
        " 0x" << std::hex << std::setw(16) << std::setfill('0') << sz <<
                 ~~~~~^
support/lockedpool.cpp:143:35: error: no member named 'setw' in namespace 'std'
        " 0x" << std::hex << std::setw(16) << std::setfill('0') << sz <<
                             ~~~~~^
support/lockedpool.cpp:143:52: error: no member named 'setfill' in namespace 'std'
        " 0x" << std::hex << std::setw(16) << std::setfill('0') << sz <<
                                              ~~~~~^
support/lockedpool.cpp:144:31: error: no member named 'endl' in namespace 'std'
        " 0x" << used << std::endl;
                         ~~~~~^
support/lockedpool.cpp:150:10: error: no member named 'cout' in namespace 'std'
    std::cout << std::endl;
    ~~~~~^
support/lockedpool.cpp:150:23: error: no member named 'endl' in namespace 'std'
    std::cout << std::endl;
                 ~~~~~^
support/lockedpool.cpp:152:9: error: no matching function for call to 'printchunk'
        printchunk(chunk.first, chunk.second, false);
        ^~~~~~~~~~
support/lockedpool.cpp:140:13: note: candidate function not viable: no known conversion from 'const std::__1::__map_const_iterator<std::__1::__tree_const_iterator<std::__1::__value_type<unsigned long, char *>, std::__1::__tree_node<std::__1::__value_type<unsigned long, char *>, void *> *, long> >' to 'size_t' (aka 'unsigned long') for 2nd argument
static void printchunk(char* base, size_t sz, bool used) {
            ^
support/lockedpool.cpp:153:10: error: no member named 'cout' in namespace 'std'
    std::cout << std::endl;
    ~~~~~^
support/lockedpool.cpp:153:23: error: no member named 'endl' in namespace 'std'
    std::cout << std::endl;
                 ~~~~~^
13 errors generated.

[Empact]

Concept ACK

[jkczyz]

Concept ACK. @jkczyz could you rebase this?

Done.

[laanwj]

ACK 30fb598

I like how minimal this change has become.

[fanquake]

ACK 30fb598 - thanks for following up jkczyz.

src/test/test_bitcoin --run_test=allocator_tests
Running 3 test cases...
0x00000000x80ffc10 0x00000000000003f0 0x1

0x00000000x8000000 0x00000000000ffc10 0x0


0x00000000x8000000 0x0000000000100000 0x0

0x00000000x80ffc80 0x0000000000000200 0x1
0x00000000x80ffe80 0x0000000000000100 0x1
0x00000000x80fff80 0x0000000000000080 0x1

0x00000000x8000000 0x00000000000ffc80 0x0

0x00000000x80ffc80 0x0000000000000200 0x1
0x00000000x80ffe80 0x0000000000000100 0x1

0x00000000x80fff80 0x0000000000000080 0x0
0x00000000x8000000 0x00000000000ffc80 0x0

0x00000000x80fff80 0x0000000000000080 0x1
0x00000000x80ffc80 0x0000000000000200 0x1

0x00000000x80ffe80 0x0000000000000100 0x0
0x00000000x8000000 0x00000000000ffc80 0x0


0x00000000x8000000 0x0000000000100000 0x0