Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UpdateTip LogPrintf() whitespaces #16657

Closed
wants to merge 3 commits into from
Closed

Fix UpdateTip LogPrintf() whitespaces #16657

wants to merge 3 commits into from

Conversation

cvasqxz
Copy link

@cvasqxz cvasqxz commented Aug 19, 2019

Added whitespaces into UpdateTip's logprintf to improve code readability.

@cvengler
Copy link
Contributor

Concept ACK e3e548f

@maflcko
Copy link
Member

maflcko commented Aug 19, 2019

Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

  • Time spent on review
  • Accidental introduction of bugs
  • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

For more information about refactoring changes and stylistic cleanup, see

Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

Let me know if you have any questions.

@maflcko maflcko closed this Aug 19, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants