Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Remove old translation files, reorganize translations #17058

Closed
wants to merge 1 commit into from
Closed

GUI: Remove old translation files, reorganize translations #17058

wants to merge 1 commit into from

Conversation

GChuf
Copy link
Contributor

@GChuf GChuf commented Oct 4, 2019

I have only noticed that all the "old" translation files are being used for v19 after being mentioned in #17027.
Due to some reorganizing on transifex, some language files should never have ended in v19. The correct way to update would be to delete all existing translation files and run the script afterwards.
This is the result.

FWIW: Why are there less files than before? It's because there was a lot of duplication on transifex. For example, Korean would be translated into (ko) as well as (ko_KR). I've deleted ko_KR in such cases, and merged such translations together to get one, more completed translation file.

I wasn't sure how to deal with 019 appropriately, so I made this PR to master.

@fanquake fanquake added the GUI label Oct 4, 2019
@GChuf
Copy link
Contributor Author

GChuf commented Oct 4, 2019

@laanwj please take a look.
note: this includes the zh_TW "fix" as well from the aforementioned issue.

This commit addresses all the changes that were done on Transifex.
This includes the rmeoval of some duplicates as well as reorganizing.
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 5, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #16966 (ui: make send a wizard by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj
Copy link
Member

laanwj commented Oct 5, 2019

@laanwj laanwj closed this Oct 5, 2019
@laanwj
Copy link
Member

laanwj commented Oct 5, 2019

The correct way to update would be to delete all existing translation files and run the script afterwards. This is the result.

Wait, I'm pretty sure the script already does this? If not, we need to fix the script so this keeps happening automatically.
You're right, it doesn't!

@laanwj
Copy link
Member

laanwj commented Oct 5, 2019

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants