doc: Remove bitness from bitcoin-qt help message and manpage #17503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `(64-bit)` from the bitcoin-qt help message. Since removing the Windows 32-bit builds, it is no longer information that is often useful for troubleshooting. This never worked for other architectures than x86, and the only 32-bit x86 build left is the Linux one. Linux users tend to know what architecture they are using. It also accidentally ends up in the bitcoin-qt manpage.
|
ACK e161bc7 -- rationale makes sense and diff looks correct :) |
|
Tested ACK e161bc7 🔮 Show signature and timestampSignature: Timestamp of file with hash |
maflcko
pushed a commit
that referenced
this pull request
Nov 18, 2019
…npage e161bc7 doc: Remove bitness from bitcoin-qt help message and manpage (Wladimir J. van der Laan) Pull request description: Remove the `(64-bit)` from the bitcoin-qt help message. Since removing the Windows 32-bit builds, it is no longer information that is often useful for troubleshooting. This never worked for other architectures than x86, and the only 32-bit x86 build left is the Linux one. Linux users tend to know what architecture they are using. It also accidentally ends up in the bitcoin-qt manpage (if you happen to be generating them on a x86 machine), which gets checked in. See for example 1bc9988#diff-e4b84be382c8ea33b83203ceb8c85296 ACKs for top commit: practicalswift: ACK e161bc7 -- rationale makes sense and diff looks correct :) MarcoFalke: Tested ACK e161bc7 🔮 Tree-SHA512: d38754903252896dc86fac6c12ad6615d322c2744db7c02b18574a08c69e8876b2c905e1f09b324002236b111ee93479f89769c562e7b3b2e6eb2992d76464ef
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 29, 2019
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 5, 2020
Summary: > Remove the `(64-bit)` from the bitcoin-qt help message. > > Since removing the Windows 32-bit builds, it is no longer information > that is often useful for troubleshooting. This never worked for other > architectures than x86, and the only 32-bit x86 build left is the Linux > one. Linux users tend to know what architecture they are using. > > It also accidentally ends up in the bitcoin-qt manpage. This is a backport of Core [[bitcoin/bitcoin#17503 | PR17503]] Test Plan: `ninja && ninja doc-manpage-bitcoin-qt` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien, majcosta Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8266
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
(64-bit)from the bitcoin-qt help message.Since removing the Windows 32-bit builds, it is no longer information that is often useful for troubleshooting. This never worked for other architectures than x86, and the only 32-bit x86 build left is the Linux one. Linux users tend to know what architecture they are using.
It also accidentally ends up in the bitcoin-qt manpage (if you happen to be generating them on a x86 machine), which gets checked in. See for example 1bc9988#diff-e4b84be382c8ea33b83203ceb8c85296