Fixed freezing GUI on reindex #17565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
reviewed
Nov 22, 2019
|
@instagibbs I've made the requested change 👍 |
laanwj
reviewed
Nov 23, 2019
| @@ -15,6 +15,7 @@ | |||
| #include <net.h> | |||
| #include <netbase.h> | |||
| #include <util/system.h> | |||
| #include <validation.h> | |||
There was a problem hiding this comment.
I don't think you're supposed to introduce a direct dependency here, either the flag should be passed in or the request should go through the node interface
@ryanofsky
There was a problem hiding this comment.
ACK, so use the node getFreindex() method.
There was a problem hiding this comment.
re: #17565 (comment)
In commit "Fixed freezing GUI on reindex" (7a633fd)
You'd replace fReindex here with clientmodel->node().getReindex()
|
Is this up for grabs? |
|
Closing as Up for grabs. |
jonasschnelli
added a commit
that referenced
this pull request
Feb 13, 2020
c9fe612 gui: Throttle GUI update pace when -reindex (Hennadii Stepanov) Pull request description: This is grabbed from #17565. All **laanwj**'s and **ryanofsky**'s suggestions are implemented. With this PR, the GUI does not freeze when a user runs: ``` $ ./src/qt/bitcoin-qt -reindex ``` ACKs for top commit: jonasschnelli: utACK c9fe612 Tree-SHA512: c7be316cb73d3d286bdf8429a960f71777d13a73d059869a64e23ad276499252b561a3a5b9613c4c1ad58cc0de26283c1ec72be745c401f604eaa05f70bf7d64
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 17, 2021
c9fe612 gui: Throttle GUI update pace when -reindex (Hennadii Stepanov) Pull request description: This is grabbed from bitcoin#17565. All **laanwj**'s and **ryanofsky**'s suggestions are implemented. With this PR, the GUI does not freeze when a user runs: ``` $ ./src/qt/bitcoin-qt -reindex ``` ACKs for top commit: jonasschnelli: utACK c9fe612 Tree-SHA512: c7be316cb73d3d286bdf8429a960f71777d13a73d059869a64e23ad276499252b561a3a5b9613c4c1ad58cc0de26283c1ec72be745c401f604eaa05f70bf7d64
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 18, 2021
c9fe612 gui: Throttle GUI update pace when -reindex (Hennadii Stepanov) Pull request description: This is grabbed from bitcoin#17565. All **laanwj**'s and **ryanofsky**'s suggestions are implemented. With this PR, the GUI does not freeze when a user runs: ``` $ ./src/qt/bitcoin-qt -reindex ``` ACKs for top commit: jonasschnelli: utACK c9fe612 Tree-SHA512: c7be316cb73d3d286bdf8429a960f71777d13a73d059869a64e23ad276499252b561a3a5b9613c4c1ad58cc0de26283c1ec72be745c401f604eaa05f70bf7d64
thelazier
pushed a commit
to thelazier/dash
that referenced
this pull request
Sep 25, 2021
c9fe612 gui: Throttle GUI update pace when -reindex (Hennadii Stepanov) Pull request description: This is grabbed from bitcoin#17565. All **laanwj**'s and **ryanofsky**'s suggestions are implemented. With this PR, the GUI does not freeze when a user runs: ``` $ ./src/qt/bitcoin-qt -reindex ``` ACKs for top commit: jonasschnelli: utACK c9fe612 Tree-SHA512: c7be316cb73d3d286bdf8429a960f71777d13a73d059869a64e23ad276499252b561a3a5b9613c4c1ad58cc0de26283c1ec72be745c401f604eaa05f70bf7d64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GUI wallet freezes on start (Loading block files for reindex)
Fix
Added a check for
fReindexin theBlockTipChangedmethod/function when update if for a headerTest
-reindex=1