mining: Fix getmininginfo currentblockweight inaccuracy #17790
Conversation
| @@ -148,12 +147,14 @@ std::unique_ptr<CBlockTemplate> BlockAssembler::CreateNewBlock(const CScript& sc | |||
| coinbaseTx.vout.resize(1); | |||
| coinbaseTx.vout[0].scriptPubKey = scriptPubKeyIn; | |||
| coinbaseTx.vout[0].nValue = nFees + GetBlockSubsidy(nHeight, chainparams.GetConsensus()); | |||
| coinbaseTx.vin[0].scriptSig = CScript() << nHeight << OP_0; | |||
| coinbaseTx.vin[0].scriptSig = CScript() << nHeight << CScriptNum(1); | |||
There was a problem hiding this comment.
The extraNonce is incremented before any block is generated, which adds 4 to the block weight. This adds an extraNonce of 1 here so that the following GetBlockWeight calculation is accurate and not 4 less.
andrewtoth
changed the title
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
andrewtoth
force-pushed
the
getmininginfo-weight
branch
from
4f6c231
to
1b177fe
Compare
|
The client/miner decides the generated outputs, so it can't be accurate... |
|
@luke-jr I see, thanks. Perhaps this should be documented in the help text then, that this field is only an estimate? At least with this patch it would be accurate for blocks created with |
getmininginfo'scurrentblockweightfield is not accurate.getblockon the latest mined block shows a different weight. This corrects that behaviour by storing the actual serialized weight instead of an estimate.