Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msvc: Ignore msvc linker warning and update to msvc build instructions. #17899

Merged
merged 1 commit into from
Jan 10, 2020
Merged

msvc: Ignore msvc linker warning and update to msvc build instructions. #17899

merged 1 commit into from
Jan 10, 2020

Conversation

sipsorcery
Copy link
Member

  • Update Visual Studio instructions.
  • Remove x64 platform conditional from bitcoin-qt project configuration.
  • Set use native environment toolset to fix linker warning.
  • Ignore linker warning about precompiled type information missing for test_bitcoin_qt.

@sipsorcery
Ignore msvc linker warning and update to msvc build instructions.
0874a10 
- Update Visual Studio instructions.
- Remove x64 platform conditional from bitcoin-qt project configuration.
- Set use native environment toolset to fix linker warning.
- Ignore linker warning about precompiled type information missing for test_bitcoin_qt.
fanquake
fanquake approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0874a10 - tested building bitcoind and bitcoin-qt. Didn't open anything in Visual Studio.

fanquake added a commit that referenced this pull request Jan 10, 2020
@fanquake
Merge #17899: msvc: Ignore msvc linker warning and update to msvc bui…
62b189b 
…ld instructions.

0874a10 Ignore msvc linker warning and update to msvc build instructions. (Aaron Clauson)

Pull request description:

  - Update Visual Studio instructions.
  - Remove x64 platform conditional from bitcoin-qt project configuration.
  - Set use native environment toolset to fix linker warning.
  - Ignore linker warning about precompiled type information missing for test_bitcoin_qt.

ACKs for top commit:
  fanquake:
    ACK 0874a10 - tested building `bitcoind` and `bitcoin-qt`. Didn't open anything in Visual Studio.

Tree-SHA512: 83a4e4dfb8a52b024feadbf06bb1bf87993b6ebcb2a1b7dc3e2385815400f0beffc43591408b4abc8b6ffa406ce066c0af5028e7f53c707dca88ea5bba18346c
@fanquake fanquake merged commit 0874a10 into bitcoin:master Jan 10, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 14, 2020
@fanquake
Merge bitcoin#17899: msvc: Ignore msvc linker warning and update to m…
4c3c68f 
…svc build instructions.

0874a10 Ignore msvc linker warning and update to msvc build instructions. (Aaron Clauson)

Pull request description:

  - Update Visual Studio instructions.
  - Remove x64 platform conditional from bitcoin-qt project configuration.
  - Set use native environment toolset to fix linker warning.
  - Ignore linker warning about precompiled type information missing for test_bitcoin_qt.

ACKs for top commit:
  fanquake:
    ACK 0874a10 - tested building `bitcoind` and `bitcoin-qt`. Didn't open anything in Visual Studio.

Tree-SHA512: 83a4e4dfb8a52b024feadbf06bb1bf87993b6ebcb2a1b7dc3e2385815400f0beffc43591408b4abc8b6ffa406ce066c0af5028e7f53c707dca88ea5bba18346c
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
@fanquake
Merge bitcoin#17899: msvc: Ignore msvc linker warning and update to m…
01b3242 
…svc build instructions.

0874a10 Ignore msvc linker warning and update to msvc build instructions. (Aaron Clauson)

Pull request description:

  - Update Visual Studio instructions.
  - Remove x64 platform conditional from bitcoin-qt project configuration.
  - Set use native environment toolset to fix linker warning.
  - Ignore linker warning about precompiled type information missing for test_bitcoin_qt.

ACKs for top commit:
  fanquake:
    ACK 0874a10 - tested building `bitcoind` and `bitcoin-qt`. Didn't open anything in Visual Studio.

Tree-SHA512: 83a4e4dfb8a52b024feadbf06bb1bf87993b6ebcb2a1b7dc3e2385815400f0beffc43591408b4abc8b6ffa406ce066c0af5028e7f53c707dca88ea5bba18346c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

@kangzixiang kangzixiang kangzixiang approved these changes

Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sipsorcery @fanquake @kangzixiang