Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumpfee test fix #18311

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Bumpfee test fix #18311

merged 2 commits into from
Mar 10, 2020

Conversation

instagibbs
Copy link
Member

@instagibbs instagibbs commented Mar 10, 2020 •
edited
Loading

In the loop we accidentally used origfee which is not the value to check, and also allowed the loop to exit too early since the new fee must be strictly greater than 0.0005.

Also converted/added a bunch of logging from comments.

Resolves #17716

@instagibbs instagibbs mentioned this pull request Mar 10, 2020
Closed
@DrahtBot DrahtBot added the Tests label Mar 10, 2020
@maflcko
Copy link
Member

maflcko commented Mar 10, 2020

ACK f1b4503 🏈

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK f1b45031148105754c23af08c891387e71c3c2c3 🏈
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgGvgwAkvzXwCDsArn/R/cQCKAPKFPl+GNz3gekt+dd27h8GPs/94lQJcFZXynQ
yetDewQNZD/jsX/Hcqm7L6SHTRF5tCAwalUxinhtppMkI1s+/WHZhkL4a2P7H/Ly
IE0j1cVwfMunbTkghFGe9d6x2kb8Spm0HUnNrPrB0CMExy/Ck+SymRpsSLprhZ93
FLbmbwcWWHoF5fydwlZpecz7h/Bi/UJB1v20YQZBSD3PXG3HnvnmRpeCM4PyM0Yw
gQNI75ms7HadiccyLpDVGJto2kSuj+WNSDV/wICKEMBxPflBjMvOEMG/BulC39V7
Pf2hvOPRUTeUxPi93ziKkd2SMDyb0UGErsJ56msUW5NBTci1EvGDUDXe8jHk9JND
BYzD5TnlKYgeT2A0YhGRHfPMjoUTtzONz85OwZKkWkF/GBUD+qFvLh9oChysuCP+
r0Zh46JtDCO3qaXFhCkuRpbGcRyY4YC6FJ9fkJV+oAjO1+5chwjGqcJNLJ8Rcir5
xGiNHth5
=hXEx
-----END PGP SIGNATURE-----

Timestamp of file with hash 2cb7f2f63d873829e88b88ecaf04dec4dacf7f4a5dff0034c9a41405f4ffb2b5 -

@maflcko maflcko merged commit b5c7665 into bitcoin:master Mar 10, 2020
jonatack
jonatack reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK efe1bb8

@jonatack
Copy link
Member

GitHub caches so aggressively, I didn't see this had been updated and then merged 🤷‍♂️

@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonatack jonatack jonatack left review comments

@maflcko maflcko maflcko left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intermittent functional test failure in wallet_bumpfee
4 participants
@instagibbs @maflcko @jonatack @DrahtBot