-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Replace remaining literal BTC with CURRENCY_UNIT. #18341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Mar 13, 2020
maflcko
changed the title
Replace remaining literal BTC with CURRENCY_UNIT.
doc: Replace remaining literal BTC with CURRENCY_UNIT.
Mar 13, 2020
I think this is ready to merge if it compiles |
Concept ACK FWIW:
|
domob1812
force-pushed
the
currency-unit
branch
from
March 13, 2020 12:52
cb645c1
to
e8a301a
Compare
Good catch (I was only targeting the RPC help texts so far, as that is what I worked on when I noticed this). I've updated the PR, replacing also the |
maflcko
reviewed
Mar 13, 2020
domob1812
force-pushed
the
currency-unit
branch
from
March 13, 2020 14:56
e8a301a
to
c9f4e26
Compare
Concept ACK. |
This replaces one remaining instance of the literal "BTC" string with the CURRENCY_UNIT constant, as is done in most of the codebase already. The other remaining instance (which is just part of a log message and thus not really user-visible) is just removed. After this change, no instance of literal "BTC" remains anywhere in the non-Qt and non-test codebase.
domob1812
force-pushed
the
currency-unit
branch
from
March 14, 2020 08:25
c9f4e26
to
7df0cf7
Compare
ACK 7df0cf7 |
ACK 7df0cf7 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 16, 2020
…_UNIT. 7df0cf7 Replace remaining literals BTC with CURRENCY_UNIT (Daniel Kraft) Pull request description: This replaces one remaining instance of the literal `"BTC"` string with the `CURRENCY_UNIT` constant, as is done in most of the codebase already. After this change, no instance of literal `"BTC"` remains anywhere in the RPC help texts. ACKs for top commit: MarcoFalke: ACK 7df0cf7 laanwj: ACK 7df0cf7 Tree-SHA512: 7f7d52b366e084c93a7d6a3c45b1bbfc4f4f50bca6956594077e6d46295977c8cc18499232878869869c73a8ab9a1c41245029ae7425a87cec2ccb0cb52eea13
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 19, 2020
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 19, 2020
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…_UNIT. 7df0cf7 Replace remaining literals BTC with CURRENCY_UNIT (Daniel Kraft) Pull request description: This replaces one remaining instance of the literal `"BTC"` string with the `CURRENCY_UNIT` constant, as is done in most of the codebase already. After this change, no instance of literal `"BTC"` remains anywhere in the RPC help texts. ACKs for top commit: MarcoFalke: ACK 7df0cf7 laanwj: ACK 7df0cf7 Tree-SHA512: 7f7d52b366e084c93a7d6a3c45b1bbfc4f4f50bca6956594077e6d46295977c8cc18499232878869869c73a8ab9a1c41245029ae7425a87cec2ccb0cb52eea13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces one remaining instance of the literal
"BTC"
string with theCURRENCY_UNIT
constant, as is done in most of the codebase already.After this change, no instance of literal
"BTC"
remains anywhere in the RPC help texts.