Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Move wallet RPCs to their own libbitcoin_walletrpcs module #18469

Closed
wants to merge 3 commits into from

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Mar 30, 2020

Attempt to fix #18465. This also trims the RPC code out of the bitcoin-wallet build.

The build currently fails for bench_bitcoin for reasons I can't figure out.

Also, I'm not really sure what is needed for MSVC.

Chasing Concept ACKs for now (or ideas for alternative directions, please post to #18465 )

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 30, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ryanofsky
Copy link
Contributor

I will be honest and say I don't really understand how this PR is trying to organize the libraries and API, but I did post an alternate fix #18465 (comment) that I think addresses the problem simply and directly

@luke-jr
Copy link
Member Author

luke-jr commented Mar 30, 2020

@ryanofsky The point here is to only link wallet RPC stuff when there is a RPC server (and therefore urlDecode)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitcoin-tx (and probably others) fails to build without libevent
4 participants