net: Use C++11 member initialization in protocol

[maflcko]

This change removes Init from the constructors and instead uses C++11 member initialization. This removes a bunch of boilerplate, makes the code easier to read. Also, C++11 member initialization avoids accidental uninitialized members.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

[practicalswift]

Concept ACK

AFAICT the suggested change is fully in line with with the recommendations in the C++ Core Guidelines (Stroustrup & Sutter):

• C.41: A constructor should create a fully initialized object: "A constructor establishes the invariant for a class. A user of a class should be able to assume that a constructed object is usable."
• C.45: Don't define a default constructor that only initializes data members; use in-class member initializers instead: "Using in-class member initializers lets the compiler generate the function for you. The compiler-generated function can be more efficient."
• C.48: Prefer in-class initializers to member initializers in constructors for constant initializers: "Makes it explicit that the same value is expected to be used in all constructors. Avoids repetition. Avoids maintenance problems. It leads to the shortest and most efficient code."
• C.49: Prefer initialization to assignment in constructors: "An initialization explicitly states that initialization, rather than assignment, is done and can be more elegant and efficient. Prevents “use before set” errors."
• ES.20: Always initialize an object: "Avoid used-before-set errors and their associated undefined behavior. Avoid problems with comprehension of complex initialization. Simplify refactoring."
• ES.23: Prefer the {}-initializer syntax: "Prefer {}. The rules for {} initialization are simpler, more general, less ambiguous, and safer than for other forms of initialization. Use = only when you are sure that there can be no narrowing conversions. For built-in arithmetic types, use = only with auto. Avoid () initialization, which allows parsing ambiguities."

[Empact]

Wouldn't unsigned int be the value to test for equivalence?

[sipa]

unsigned is a shorthand for unsigned int.

[maflcko]

I think this check is redundant anyway, because prepending a type with unsigned shouldn't change it's bitlength. But I didn't feel like looking that up and adding the check has no downsides.

[laanwj]

ACK fa8bbb1
Nice cleanup. Checked that nTime's (100000000) and nServices (NODE_NONE) initial value stays the same in all cases.