Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: Add missing QPainterPath include #19097

Merged
merged 1 commit into from
May 29, 2020
Merged

qt: Add missing QPainterPath include #19097

merged 1 commit into from
May 29, 2020

Conversation

achow101
Copy link
Member

This is needed to compile with Qt 5.15.

@achow101
Add missing QPainterPath include
79b0a69 
This is needed to compile with Qt 5.15.
@DrahtBot DrahtBot added the GUI label May 28, 2020
@laanwj
Copy link
Member

laanwj commented May 28, 2020

Code review ACK 79b0a69

@maflcko
Copy link
Member

maflcko commented May 28, 2020

Code review ACK 79b0a69

@promag
Copy link
Member

promag commented May 28, 2020

Code review ACK 79b0a69.

nit, could also forward declare in src/qt/trafficgraphwidget.h.

@fanquake fanquake merged commit adc143f into bitcoin:master May 29, 2020
@bitcoin bitcoin deleted a comment from vahidjalaliii May 29, 2020
@fanquake fanquake added this to the 0.20.1 milestone May 29, 2020
@promag promag mentioned this pull request Jun 2, 2020
Closed
@puchu
Copy link
Contributor

puchu commented Jun 2, 2020

Code review ACK 79b0a69.

nit, could also forward declare in src/qt/trafficgraphwidget.h.

should be in the h file as it's already used there

@promag
Copy link
Member

promag commented Jun 2, 2020

Definition isn't necessary in the header, forward declaration is enough.

@puchu
Copy link
Contributor

puchu commented Jun 2, 2020 •
edited
Loading

but what's the benefit, instead of directly including it in the h file?

would actually save one line of code ;)

@promag
Copy link
Member

promag commented Jun 2, 2020

It's usually best practice to just include an header when the definition is required to minimize the compiler work.

@puchu
Copy link
Contributor

puchu commented Jun 2, 2020

makes sense

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Jun 4, 2020
@achow101 @luke-jr
Add missing QPainterPath include
384d3f9 
This is needed to compile with Qt 5.15.

Github-Pull: bitcoin#19097
Rebased-From: 79b0a69
@luke-jr luke-jr mentioned this pull request Jun 4, 2020
Merged
maflcko pushed a commit that referenced this pull request Jun 4, 2020
Merge #19170: [0.20] Add missing QPainterPath include
cd32134 
384d3f9 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

  Github-Pull: #19097
  Rebased-From: 79b0a69

Top commit has no ACKs.

Tree-SHA512: 23c4604cddb0bf5955afa6dfb6be87989df591e5f5ca5b85257c72e916f29337012b24c9ab5374a3289700ab7518ddb48f21195a2173ea1f935d69bd2ad13b8b
This was referenced Jun 7, 2020
Closed
Merged
@fanquake fanquake mentioned this pull request Jul 14, 2020
Closed
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jul 15, 2020
@achow101 @fanquake
Add missing QPainterPath include
b7e16a8 
This is needed to compile with Qt 5.15.

Github-Pull: bitcoin#19097
Rebased-From: 79b0a69
@fanquake fanquake mentioned this pull request Jul 15, 2020
Merged
maflcko pushed a commit that referenced this pull request Aug 11, 2020
Merge #19025: [0.19] Backports
28a9df7 
be95147 Updated appveyor job to checkout a specific vcpkg commit ID. (Aaron Clauson)
1fd9cd2 appveyor: Remove clcache (MarcoFalke)
8c0a959 Remove cached directories and associated script blocks from appveyor CI configuration. (Aaron Clauson)
d70f700 lint: fix shellcheck URL in CI install (fanquake)
f8f7d91 test: remove Cirrus CI FreeBSD job (fanquake)
b7e16a8 Add missing QPainterPath include (Andrew Chow)
30a2814 gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (João Barbosa)
0d87a5b QA: feature_segwit: Check that template "rules" includes "!segwit" as appropriate (Luke Dashjr)
bde6a5a Bugfix: Include "csv","!segwit" in "rules" (Luke Dashjr)
e422f65 build: Set libevent minimum version to 2.0.21 (Hennadii Stepanov)
0d0dd6a Update with new Windows code signing certificate (Andrew Chow)

Pull request description:

  Backports the following to the 0.19 branch:

  * #17946 - Fix GBT: Restore "!segwit" and "csv" to "rules" key
  * #18160 - gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged
  * #18425 - releases: Update with new Windows code signing certificate
  * #18676 - build: Check libevent minimum version in configure script
  * #19097 - qt: Add missing QPainterPath include (as per #19510)
  * #18640 - appveyor: Remove clcache
  * #19444 - test: Remove cached directories and associated script blocks from appveyor config
  * #19612 - lint: fix shellcheck URL in CI install
  * #18001 -  Updated appveyor job to checkout a specific vcpkg commit ID

  Closes: #19510.

ACKs for top commit:
  jnewbery:
    ACK be95147
  MarcoFalke:
    cherry-pick ACK be95147 🌎

Tree-SHA512: 2ec7e3ae1da99799ff6f8cfe26095d6885cffe6952b18a7e236dc5e657b3918225c2601b8c8e17cdff5319c40cb0a214d9fad49b0ff2f54af1db7c81d83a1df5
@fanquake fanquake mentioned this pull request Aug 14, 2020
Closed
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Oct 21, 2020
@achow101 @Bushstar
Add missing QPainterPath include
e4ff5b1 
This is needed to compile with Qt 5.15.

Github-Pull: bitcoin#19097
Rebased-From: 79b0a69
Platinumwrist referenced this pull request in syscoin/syscoin Oct 25, 2020
@laanwj
doc: Add historical release notes for 0.20.1
05e2740
buzzkillb added a commit to buzzkillb/denarius that referenced this pull request Dec 5, 2020
@buzzkillb
qt: Add missing QPainterPath include
c44ebe0 
To compile with newer QT. bitcoin/bitcoin#19097
@buzzkillb buzzkillb mentioned this pull request Dec 5, 2020
Merged
blockstreamsatellite pushed a commit to Blockstream/bitcoinsatellite that referenced this pull request Jan 29, 2021
@achow101 @blockstreamsatellite
Add missing QPainterPath include
38fd49d 
This is needed to compile with Qt 5.15.

Github-Pull: bitcoin#19097
Rebased-From: 79b0a69
backpacker69 referenced this pull request in peercoin/peercoin Mar 28, 2021
@achow101 @backpacker69
Add missing QPainterPath include
7bb20af 
This is needed to compile with Qt 5.15.

Github-Pull: #19097
Rebased-From: 79b0a69
This was referenced Jun 5, 2021
Closed
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
4f81faa 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
d5ab2cb 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
73ea0c4 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
44339c6 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
eba7d8a 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 14, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
286290b 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19097: qt: Add missing QPainterPath include
68e1c05 
79b0a69 Add missing QPainterPath include (Andrew Chow)

Pull request description:

  This is needed to compile with Qt 5.15.

ACKs for top commit:
  laanwj:
    Code review ACK 79b0a69
  MarcoFalke:
    Code review ACK 79b0a69
  promag:
    Code review ACK 79b0a69.

Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
0.20.1
Development

Successfully merging this pull request may close these issues.
7 participants
@achow101 @laanwj @maflcko @promag @puchu @fanquake @DrahtBot