Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: change CNetAddr::ip to have flexible size #19628

Merged
merged 2 commits into from
Aug 25, 2020
+496 −267
Merged

net: change CNetAddr::ip to have flexible size #19628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ea57ad
net: don't accept non-left-contiguous netmasks
vasild Aug 24, 2020
102867c
net: change CNetAddr::ip to have flexible size
vasild Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ Updated settings
in future releases. Refer to the help of the affected settings `-whitebind`
and `-whitelist` for more details. (#19191)

- Netmasks that contain 1-bits after 0-bits (the 1-bits are not contiguous on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps point out where these are used. I think the -rpcallowip parameter, and the setban RPC are the only ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do so in a followup.

the left side, e.g. 255.0.255.255) are no longer accepted. They are invalid
according to RFC 4632.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append " (#19628)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do so in a followup, to keep the current ACKs.


Changes to Wallet or GUI related settings can be found in the GUI or Wallet section below.

Tools and Utilities
Expand Down