Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused header <arpa/inet.h> in protocol.cpp #19890

Merged
merged 1 commit into from
Sep 6, 2020
Merged

refactor: remove unused header <arpa/inet.h> in protocol.cpp #19890

merged 1 commit into from
Sep 6, 2020

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Sep 6, 2020

There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since #735, more than 8 years ago!), hence the header include can be removed.

@practicalswift
Copy link
Contributor

ACK 2f79e9d -- patch looks correct and CI is happy

Thanks a lot for removing legacy cruft! Future generations of Bitcoin Core developers will thank you! :)

promag
promag reviewed Sep 6, 2020
View reviewed changes
Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 2f79e9d.

@epson121
Copy link

epson121 commented Sep 6, 2020

Code review ACK 2f79e9d

I've looked into possible remaining usage of any types, structures, macros or functions defined in arpa/inet.h in changed file, and there aren't any (man page)

@laanwj
Copy link
Member

laanwj commented Sep 6, 2020 •
edited
Loading

ACK 2f79e9d
also verified that no hton* or inet_ functions are used in protocol.cpp (nor in_addr)

@laanwj laanwj merged commit 68d1f16 into bitcoin:master Sep 6, 2020
@theStack theStack deleted the 20200823-refactor-remove-unsused-include-in-protocol-cpp branch December 1, 2020 09:54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
8c218b5 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
38a3f83 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
67af26c 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
1080fb5 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
86e35f6 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
a08693f 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#19890: refactor: remove unused header <arpa/inet.h> in …
2ede320 
…protocol.cpp

2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner)

Pull request description:

  There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed.

ACKs for top commit:
  practicalswift:
    ACK 2f79e9d -- patch looks correct and CI is happy
  epson121:
    Code review ACK 2f79e9d
  laanwj:
    ACK 2f79e9d
  promag:
    Code review ACK 2f79e9d.

Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 23, 2021
@theStack @PiRK
refactor: remove unused header <arpa/inet.h> in protocol.cpp
47b8417 
Summary:
> There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since #735, more than 8 years ago!), hence the header include can be removed.

This is a backport of [[bitcoin/bitcoin#19890 | core#19890]]

Test Plan: `ninja`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10184
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@promag promag promag left review comments

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theStack @practicalswift @epson121 @laanwj @promag @fanquake