Restore FIRST_CLASS_MESSAGING #2014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NACK |
|
We had this discussion many times before, this is just not coming back |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d0c637aecbd19506846f35e21b446e856a5e6ab5 for binaries and test log. |
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Apr 6, 2018
* Allow disabling txindex in lite mode * Do not load/store Dash-specific cache in lite mode * Do not create/show masternode tab in lite mode * Do not connect PS actions in lite mode * Fix sync/ignore block updates in Dash submodules in lite mode Conflicts: src/init.cpp
KolbyML
pushed a commit
to KolbyML/bitcoin
that referenced
this pull request
Dec 5, 2020
…recipient is shielded daa5d7f Test: add coverage for sendmany + shield address (random-zebra) 13ddf93 RPC: Document shielded recipients in sendmany help (random-zebra) 8ecf222 [Wallet] Spend from delegations added to SaplingOperation (random-zebra) 267ae07 [RPC] Redirect sendmany to 'shieldedsendmany "from_transparent"' (random-zebra) 40b6f7e BUG: fix spending of P2CS in RPC sendmany (random-zebra) Pull request description: Instead of throwing an error, let's repack the json request and send it to `shieldedsendmany`. This makes the integration of send-to-shield-address much easier for third-party services. We keep the old implementation of `sendmany` for `t->t` transactions, until the two flows are properly abstracted. Also fix a minor bug found in `sendmany` (not properly considering the `fIncludeDelegated` flag), and add capability to spend P2CS inside `SaplingOperation`. Note: the same thing proposed here, could be done with the RPC `sendtoaddress` (future). ACKs for top commit: furszy: Nice, utACK daa5d7f . More than ready to get merged then :) Fuzzbawls: utACK daa5d7f Tree-SHA512: 8ecf996687cab5236c95ceaa8be5dfee660e3c984e00c005b75731103bfe8354719a7f9c91ab70665b8d0149bd52dbe222bd1ec9b845ab50587286b89028044c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.