Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...). #20519

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...). #20519

merged 2 commits into from
Dec 1, 2020

Conversation

practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 27, 2020 •
edited

Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value.

Add [[nodiscard]] to RenameOver(...) to reduce the risk of similar rename issues in the future.

vasild
vasild approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ce9dd45

This was the only place where the return value of RenameOver() was not inspected.

Would be useful to print the reason for the rename failure, but that's out of the scope of this PR.

theStack
theStack approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ce9dd45 🏷️

luke-jr
luke-jr approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@maflcko maflcko merged commit ffd5e7a into bitcoin:master Dec 1, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 1, 2020
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
161efc8 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
@practicalswift practicalswift deleted the renameover-nodiscard branch April 10, 2021 19:43
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
f8fa180 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
7a09b5d 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
d6e7776 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
c548bdd 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
fc54ece 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
aa566e5 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
7920dce 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 17, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
5bda1b9 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 19, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
d8a9d79 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 21, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
1d8363e 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 24, 2021
@PastaPastaPasta
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
4d8f035 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 12, 2021
@kwvg
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
78b174a 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 26, 2022
@practicalswift @PiRK
Handle rename failure in DumpMempool(...) by using RenameOver(...) re…
7bb2559 
…turn value

Summary:
This is a backport of [[bitcoin/bitcoin#20519 | core#20519]]
Depends on D10889

Test Plan:
`ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10891
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Apr 19, 2022
@gades
Merge bitcoin#20519: Handle rename failure in DumpMempool(...) by usi…
aa65153 
…ng the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...).

ce9dd45 Add [[nodiscard]] to RenameOver(...) (practicalswift)
9429a39 Handle rename failure in DumpMempool(...) by using RenameOver(...) return value (practicalswift)

Pull request description:

  Handle rename failure in `DumpMempool(...)` by using the `RenameOver(...)` return value.

  Add `[[nodiscard]]` to `RenameOver(...)` to reduce the risk of similar rename issues in the future.

ACKs for top commit:
  vasild:
    ACK ce9dd45
  theStack:
    ACK ce9dd45 🏷️

Tree-SHA512: 1e63d7f3061e1f6ea2df5750dbc1547a39bd50b6c529812a0c8a0c11d3100c241afdf14094e69b69a38bade7e54a12b2a42888545874398eaf5d02421b57e874
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theStack theStack theStack approved these changes

@vasild vasild vasild approved these changes

@luke-jr luke-jr luke-jr approved these changes

Assignees
No one assigned
Labels
Utils/log/libs Validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@practicalswift @theStack @vasild @luke-jr @maflcko @DrahtBot