Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix wallet_multiwallet issue on windows #20540

Merged
merged 1 commit into from
Dec 2, 2020
Merged

test: Fix wallet_multiwallet issue on windows #20540

merged 1 commit into from
Dec 2, 2020

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 1, 2020

The error message on windows:

2020-11-30T18:10:47.536032Z ListWalletDir: Error scanning C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20201130_181042\wallet_multiwallet_0\node0\regtest\wallets\self_walletdat_symlink: boost::filesystem::status: The name of the file cannot be resolved by the system: "C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20201130_181042\wallet_multiwallet_0\node0\regtest\wallets\self_walletdat_symlink\wallet.dat"

@maflcko maflcko requested a review from luke-jr December 1, 2020 12:39
@fanquake fanquake added the Tests label Dec 1, 2020
promag
promag reviewed Dec 1, 2020
View reviewed changes
Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fada2df. Although it could ignore (don't log) directories that lead to no permission error.

fanquake
fanquake approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fada2df

@maflcko maflcko merged commit 607c844 into bitcoin:master Dec 2, 2020
@maflcko maflcko deleted the 2012-testmw branch December 2, 2020 10:41
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 2, 2020
Merge bitcoin#20540: test: Fix wallet_multiwallet issue on windows
f552fbd 
fada2df test: Fix wallet_multiwallet issue on windows (MarcoFalke)

Pull request description:

  The error message on windows:

  > 2020-11-30T18:10:47.536032Z ListWalletDir: Error scanning C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20201130_181042\wallet_multiwallet_0\node0\regtest\wallets\self_walletdat_symlink: boost::filesystem::status: The name of the file cannot be resolved by the system: "C:\Users\user\AppData\Local\Temp\test_runner_₿_🏃_20201130_181042\wallet_multiwallet_0\node0\regtest\wallets\self_walletdat_symlink\wallet.dat"

ACKs for top commit:
  promag:
    Code review ACK fada2df. Although it could ignore (don't log) directories that lead to no permission error.
  fanquake:
    ACK fada2df

Tree-SHA512: b475162cc3cd1574209d916605b229a79c8089714295f5e16569b71f958f0007d54dc76833938492d931387784588b11b73e3ef00f963540af42c079417f8d72
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@promag promag promag left review comments

@fanquake fanquake fanquake approved these changes

@luke-jr luke-jr Awaiting requested review from luke-jr

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maflcko @fanquake @promag