tests: Test that a fully signed tx given to signrawtx is unchanged #20562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Dec 3, 2020
Tests that a fully signed transaction given to signrawtransactionwithwallet is both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete.
achow101
force-pushed
the
test-signraw-fullysigned
branch
from
2ae2c22
to
773c42b
Compare
|
ACK 773c42b 🕶 Show signature and timestampSignature: Timestamp of file with hash |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 4, 2020
…rawtx is unchanged 773c42b tests: Test that a fully signed tx given to signrawtx is unchanged (Andrew Chow) Pull request description: Tests that a fully signed transaction given to `signrawtransactionwithwallet` is both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete. ACKs for top commit: MarcoFalke: ACK 773c42b 🕶 Tree-SHA512: b32afd5f2667c817ee59c37af78cb37352e7c22d0271833d446fd61f11b354974694128a3b408f214db459caef3fd67ecdbf1664280ac2de602215f05aa4a6de
achow101
added a commit
to achow101/bitcoin
that referenced
this pull request
Dec 5, 2020
Tests that a fully signed transaction given to signrawtransactionwithwallet is both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete. Github-Pull: bitcoin#20562 Rebased-From: 773c42b
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Mar 6, 2021
Tests that a fully signed transaction given to signrawtransactionwithwallet is both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete. Github-Pull: bitcoin#20562 Rebased-From: 773c42b
|
Backported in #20901 |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 26, 2022
Summary: > Tests that a fully signed transaction given to > `signrawtransactionwithwallet` is both unchanged and marked as complete. > This tests for a regression in Bitcoin Core 0.20 where the transaction would not be > marked as complete. We do not have the regression in Bitcoin ABC and it seems unlikely that it will happen, as it was bissected to [[bitcoin/bitcoin#16528 | core#16528]] which we already finished backporting, and had to be fixed only on Core 0.20 (not master). But just in case, it is better to have the test to avoid any bad surprise. This is a backport of [[bitcoin/bitcoin#20562 | core#20562]] Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10894
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that a fully signed transaction given to
signrawtransactionwithwalletis both unchanged and marked as complete. This tests for a regression in 0.20 where the transaction would not be marked as complete.