Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.21.1]: rc1 Backports #20901

Merged
merged 24 commits into from
Mar 24, 2021
Merged

[0.21.1]: rc1 Backports #20901

merged 24 commits into from
Mar 24, 2021

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jan 11, 2021

Current backports for 0.21.1.

One conflict was in the test case.

Allow creation of valid `CSubNet` objects of non-IP networks and only
match the single address they were created from (like /32 for IPv4 or
/128 for IPv6).

This fixes a deficiency in `CConnman::DisconnectNode(const CNetAddr& addr)`
and in `BanMan` which assume that creating a subnet from any address
using the `CSubNet(CNetAddr)` constructor would later match that address
only. Before this change a non-IP subnet would be invalid and would not
match any address.

Github-Pull: bitcoin#20852
Rebased-From: 94d335d
Co-authored-by: Jon Atack <jon@atack.com>

Github-Pull: bitcoin#20852
Rebased-From: 39b4329
@maflcko maflcko added this to the 0.21.1 milestone Jan 11, 2021
@maflcko
Copy link
Member Author

maflcko commented Jan 11, 2021

Some gui changes that might be good to include: https://github.com/bitcoin-core/gui/milestone/3

luke-jr and others added 7 commits January 13, 2021 17:56
The SendConfirmationDialog is used for bumping the fee, where "Send" doesn't really make sense

Github-Pull: #bitcoin-core/gui#148
Rebased-From: 8775691
This change (1) prevents overlapping date and amount strings,
and (2) guaranties that "eye" sign at the end of the watch-only
address/label is always visible.

Github-Pull: bitcoin-core/gui#176
Rebased-From: f0d0479
Layouts of the hidden widgets, those are children of QStackedWidget,
could prevent to adjust the size of the parent widget in the
WalletFrame widget.

Github-Pull: bitcoin-core/gui#176
Rebased-From: af58f5b
The "macintosh" style is broken on macOS Big Sur at least for Qt 5.9.8.

Github-Pull: #bitcoin-core/gui#177
Rebased-From: 4e1154d
@laanwj
Copy link
Member

laanwj commented Feb 3, 2021

Commit list ACK 6dc58e9

brunoerg and others added 3 commits February 8, 2021 08:51
Signed-off-by: practicalswift <practicalswift@users.noreply.github.com>

Github-Pull: bitcoin#21043
Rebased-From: 3ddbf22
@gruve-p
Copy link
Contributor

gruve-p commented Feb 12, 2021

ACK 08dada8

Tests that a fully signed transaction given to
signrawtransactionwithwallet is both unchanged and marked as complete.
This tests for a regression in 0.20 where the transaction would not be
marked as complete.

Github-Pull: bitcoin#20562
Rebased-From: 773c42b
@jonatack
Copy link
Contributor

If docs fixes are backportable, maybe #21384.

sipsorcery and others added 7 commits March 21, 2021 08:40
Previously vcpkg was relying on https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz which is no longer available. The vcpkg source has been updated to use http://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-2-any.pkg.tar.zst. This PR updates the commit ID used to checkout vcpkg for the updated URL.

Github-Pull: bitcoin#21446
Rebased-From: b9e3f35
Upstream revision: https://github.com/llvm/llvm-project/blob/6d0488f75bb2f37bcfe93fc8f59f6e78c9a0c939/compiler-rt/include/fuzzer/FuzzedDataProvider.h

Changes:
* [compiler-rt] FuzzedDataProvider: add ConsumeData and method.
* [compiler-rt] Fix a typo in a comment in FuzzedDataProvider.h.
* [compiler-rt] Add ConsumeRandomLengthString() version without arguments.
* [compiler-rt] Refactor FuzzedDataProvider for better readability.
* [compiler-rt] FuzzedDataProvider: make linter happy.
* [compiler-rt] Mark FDP non-template methods inline to avoid ODR violations.

Github-Pull: bitcoin#20740
Rebased-From: e3d2ba7
The removed commit is wrong since v0.21.0.

Github-Pull: bitcoin#21342
Rebased-From: f1f63ac
@maflcko
Copy link
Member Author

maflcko commented Mar 21, 2021

Fixed fuzz build failure and appveyor ci bug. This is now ready for review/merge.

Should be relatively easy to review, because most commits are clean cherry-picks beside one or two trivial conflicts.

@ajtowns
Copy link
Contributor

ajtowns commented Mar 22, 2021

ACK 5a2d98c -- checked 'rebased-from' patches are in master, and rebased patches are clean rebases (except for the first one which changes ""s to std::string("") to avoid c++17 dependency). commits seem fine, but haven't reviewed in detail.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5a2d98c - branched off 0.21 and redid the backports. Minor conflict in c33fbab. The diff between my branch and #20901 was just in release notes, _CLIENT_VERSION_RC (#20901 branched before 95ea54b) and #21490 which has already been merged into 0.21.

@fanquake fanquake merged commit a30fd40 into bitcoin:0.21 Mar 24, 2021
@maflcko maflcko deleted the 2101-2101Backports branch March 24, 2021 05:49
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet