Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Only use credits for pull requests to the main repo #20680

Merged
merged 1 commit into from
Dec 17, 2020
Merged

ci: Only use credits for pull requests to the main repo #20680

merged 1 commit into from
Dec 17, 2020

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 17, 2020

No need to spend credits for the master branch, because the build shouldn't fail there anyway and it is not time-critical to get a fast feedback.

Some other changes:

  • Disable stateful for faster scheduling
  • Reduce lint memory from 8G to 1G for faster scheduling

@DrahtBot DrahtBot added the Tests label Dec 17, 2020
hebasto
hebasto reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.

.cirrus.yml
compute_credits_template: &CREDITS_TEMPLATE
# https://cirrus-ci.org/pricing/#compute-credits
# Only use credits for pull requests to the main repo
use_compute_credits: $CIRRUS_REPO_FULL_NAME == 'bitcoin/bitcoin' && $CIRRUS_PR != ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are pulls into the GUI repo skipped intentionally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a separate org, so billing would need to be set up separately. Is there a lot of traffic on the gui repo, so that this is needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No much traffic :)

hebasto
hebasto approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK facf5e3, I have reviewed the code and it looks OK, I agree it can be merged.

@maflcko maflcko merged commit 83abd6b into bitcoin:master Dec 17, 2020
@maflcko maflcko deleted the 2012-ciCredits branch December 17, 2020 09:46
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maflcko @hebasto @DrahtBot