add rescan bool to importprivkey to control whether to do a rescan after import #2080
Conversation
| pwalletMain->ScanForWalletTransactions(pindexGenesisBlock, true); | ||
| pwalletMain->ReacceptWalletTransactions(); | ||
|
|
||
| if (fRescan) { |
There was a problem hiding this comment.
Nit: our coding style is:
4 space indenting, no tabs
(see doc/coding.txt)
There was a problem hiding this comment.
My mistake, fixed now.
|
Now you just need to merge your 2 commits into one. |
| pwalletMain->ReacceptWalletTransactions(); | ||
| if (fRescan) { | ||
| pwalletMain->ScanForWalletTransactions(pindexGenesisBlock, true); |
There was a problem hiding this comment.
And this are still only 2 spaces (same above and below).
|
Thank you for the feedback, I just rebased so I think it's just one commit now with proper spacing. |
|
Now fix the commit message, and you're golden. ACK on the code change. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/331bc98a7fb0aa5bee965faa8cf1a58868d28558 for binaries and test log. |
|
I removed the mention of the tabs and spaces from the commit, I assume that is what was wrong with the message. Thanks for the ACK. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/44051af1a87a5fb8f4e88442c0eb64a1b4ecf2e6 for binaries and test log. |
add rescan bool to importprivkey to control whether to do a rescan after import
add rescan bool to importprivkey to control whether to do a rescan after import
I use a lot of vanity addresses and I don't need to rescan the chain when importing. I like the ability to optionally request not to do a rescan. Attached is a working example of this.