-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: Clarify disconnect log message in ProcessGetBlockData, remove send bool #21235
Conversation
maflcko
commented
Feb 19, 2021
- Clarify that "ignoring" really means "disconnect" in the log
- Revive a refactor I took from Simplify ProcessGetBlockData execution by removing send flag #13670
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c56f140 ♻️
Quite surprising that the PR where the second commit is taken from was never merged, at least IMHO getting rid of this unnecessary state variable is a definitive improvement w.r.t. readability.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c56f140
Thanks for doing this. I've also had a branch floating around to remove this variable.
Couple of small style suggestions inline.
fac5641
to
fa55ab8
Compare
utACK fa55ab8 Very nice to remove the indenting in a separate commit 💯 |
Concept ACK Returning early here makes the code more robust and easier to reason about. Glad to see |
fa55ab8
to
7ed5210
Compare
Rebased. Should be trivial to re-ACK |
🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file. |
Setting the send flag to false can be replaced by simply returning.
Can be reviewed with --ignore-all-space
7ed5210
to
fa81773
Compare
Rebased after conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK fa81773
utACK fa81773 the range-diff was a bit messy so I just reviewed again from scratch. |