Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix feature_notifications.py intermittent issue #21777

Merged
merged 1 commit into from
Apr 26, 2021
Merged

test: Fix feature_notifications.py intermittent issue #21777

merged 1 commit into from
Apr 26, 2021

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Apr 26, 2021 •
edited
Loading

Fixes #21683

@fanquake fanquake added the Tests label Apr 26, 2021
jonatack
jonatack reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I've been unable to reproduce the issue locally but this fix looks like it would resolve the CI failures without affecting the validity of the test.

@maflcko maflcko merged commit 683dda2 into bitcoin:master Apr 26, 2021
@maflcko maflcko deleted the 2104-testFix branch April 26, 2021 16:08
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 26, 2021
Merge bitcoin#21777: test: Fix feature_notifications.py intermittent …
6018f87 
…issue

fa4aec2 test: Fix feature_notifications.py intermittent issue (MarcoFalke)

Pull request description:

  Fixes bitcoin#21683

Top commit has no ACKs.

Tree-SHA512: 256806d82877477f4b3d795658f61127c0de4eff07216f6071f40a8ec1f5d43f3c587f35dd436d480dc261ef6646ac5547db104d22f3fcfeeb61bbdbe04bcc31
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 683dda2 into merged_master (Bitcoin PR bitcoin/bitcoin#21777)
e8fbb8c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonatack jonatack jonatack left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature_notifications.py cirrus test failure: IndexError: string index out of range
3 participants
@maflcko @jonatack @fanquake