make ParseOutputType return a std::optional<OutputType> #22621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
jnewbery
reviewed
Aug 4, 2021
jnewbery
reviewed
Aug 4, 2021
fanquake
force-pushed
the
parse_output_type_optional
branch
from
fb52c43
to
32fa49a
Compare
|
utACK 32fa49a |
maflcko
reviewed
Aug 4, 2021
There was a problem hiding this comment.
review ACK 32fa49a 🍢
Show signature and timestamp
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
review ACK 32fa49a18497a9b8c72e36a72ae96e7b23930223 🍢
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjxxwwAp2eMiuTSDyQF/v+XmEeFfPIBci2/mHzpaBanvLWTPpDEt4DBLcMExSyA
kNiGFoOOZWLjW00otIdoxVvEEaspLbA4LhBKqHnnoC0S9ubQwzCvYy3X9N7PraYi
LdSa58PASEwPwpu1XUs6ZfAdf7PmsVyeZzbnILfvx+IHp1jjAWQBNII5nSLoVZBq
YX+KJZW1bOzWsmqbZeZ+uYtx7XEoiB8wvx7IS5Q/DRvHjt5yu+rkILvjQ+GDj5jm
OlpD/QT02oWSHI3caS3ZPKswQ1+rSkgN7gA4JCQ5Y3G1EQgwL1HxNvp0QfYx0Zmy
VW9xWri9iRal9lVRciMWuya/qNoBT/aJzRhg6iwi6EVTBq3+Yw9Lq6o/l2X6EPSs
meFCAPdFMJx9CSGQYx7MPHTDbCID7gN85iSyuvuBTUnWKtNJuZbDBsja2qlPseph
MG/bMDXwSZHxfgFFSAze6Dh9ndZOEOnR5DkXd9rdekK1d8llBSDORuBtVFoXkzfw
OuZk3zp0
=Qnra
-----END PGP SIGNATURE-----
Timestamp of file with hash 91c943e8fe3b8d3fba23d0d084119eabd4fe46e1ab28f6b682bc8aa124a49d61 -
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 4, 2021
…utType> 32fa49a make ParseOutputType return a std::optional<OutputType> (fanquake) Pull request description: Similar to bitcoin#22220. Skipped using `auto` here for the same reasons outlined in that PR. ACKs for top commit: jnewbery: utACK 32fa49a jonatack: Code review ACK 32fa49a and debian clang 13 debug build is clean / unit tests locally are green MarcoFalke: review ACK 32fa49a 🍢 Tree-SHA512: 7752193117669b800889226185d49d164395697853828f8acb568f07651789bc5b2cddc45555957450353886e46b9a1e13c77a5e730a14c6ee621fabc8dc3d10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #22220. Skipped using
autohere for the same reasons outlined in that PR.