Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter listaddressgroupings #2291

Closed
wants to merge 2 commits into from
Closed

Conversation

mb300sd
Copy link
Contributor

@mb300sd mb300sd commented Feb 9, 2013

My old patch for coin control converted to a pull.

  • Added ability to filter empty groups and empty address from listaddressgroupings output.
  • Output an object that's easier to work with than an array of different types.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d9ab371f837476f863ca5c7a96e52f7f052f8246 for binaries and test log.

@jgarzik
Copy link
Contributor

jgarzik commented Jun 19, 2013

Your output is superior to the existing output. However, I am forced to NAK because it breaks the existing API.

Given the lack of interest in this pull request, inclined to close for lack of interest plus API issue.

@luke-jr
Copy link
Member

luke-jr commented Jul 16, 2013

@jgarzik How does this break the existing API? From a readover, it seems to behave the same when called without options...?

@luke-jr
Copy link
Member

luke-jr commented Jul 17, 2013

@mb300sd BTW, this needs a rebase.

Conflicts:
	src/bitcoinrpc.cpp
	src/rpcwallet.cpp
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4c4c4d79046cc6523fcfa300485146a2bfead319 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@gavinandresen
Copy link
Contributor

NACK: jgarzik is correct, this changes the RPC API, which is unacceptable:

Output of listaddressgroupings before:

    [
        [
            "miD5tprKXUrU97H5fK7pKfwyTH9aDgi5vd",
            50.00070000
        ]
    ]

After:

    [
        {
            "address" : "miD5tprKXUrU97H5fK7pKfwyTH9aDgi5vd",
            "balance" : 50.00070000
        }
    ]

Closing. Please open a new pull request if you come up with a backwards-compatible solution.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
@maflcko maflcko removed the CI failed label Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants