build: Copy appropriate MSVC build output to src/qt automatically #22917
Conversation
This functionality is already present for non-qt output since bitcoin#16308.
| <Copy SourceFiles="@(BuildArtifacts)" SkipUnchangedFiles="true" DestinationFolder="..\..\src\qt\" Condition="'$(OutDir)' != ''"></Copy> | ||
| </Target> | ||
| <Import Project="common.qt.vcxproj.user" Condition="Exists('common.qt.vcxproj.user')" /> | ||
| </Project> |
There was a problem hiding this comment.
Do the Qt exe's need to be copied to src\qt for any paricular reason? Is that where the test scripts look for them? I believe Nicolas originally added the common.vcxproj config to copy the exe's to the src directory for conveniece. Perhaps it's sufficient here as well and avoids the need for the new common.qt.vcxproj file?
There was a problem hiding this comment.
No test script uses bitcoin-qt.exe. The only reason is my confusion:
Not finding
bitcoin-qt.exe... in thesrc\qt\folder could confuse users.
Probably, it is just my biased personal opinion.
There was a problem hiding this comment.
If the test scripts don't need it in src\qt then I would recommend just including common.vcxproj and not bothering with the new common.qt.vcxproj file. Windows devs will normally look in the default output directory of build_msvc\x64\Release directory.
There was a problem hiding this comment.
Windows devs will normally look in the default output directory of
build_msvc\x64\Releasedirectory.
Agree. Going to close this.
This functionality is already present for non-qt output since #16308, and it was skipped to add in #15529.
Not finding
bitcoin-qt.exeandtest_bitcoin-qt.exein thesrc\qt\folder could confuse users.This PR fixes that issue in the same way like #16308 did.