test: Use MiniWallet in mempool_persist #23047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 20, 2021 15:48
The nodes are stopped in the next line, no need to connect them
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| self.log.debug("Stop-start node0 with -persistmempool=0. Verify that it doesn't load its mempool.dat file.") | ||
| self.stop_nodes() | ||
| self.start_node(0, extra_args=["-persistmempool=0", "-disablewallet"]) | ||
| self.start_node(0, extra_args=["-persistmempool=0"]) |
There was a problem hiding this comment.
shouldn't node be started with disabled wallet?
There was a problem hiding this comment.
Feel free to ignore this but you can use self.restart_node() here.
There was a problem hiding this comment.
No wallet (that has any unconfirmed txs) should exist for node 0
|
Code review ACK faae098 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 24, 2021
faae098 test: Check other fields are loaded correctly as well (MarcoFalke) fa4db92 test: Remove unused self.connect_nodes (MarcoFalke) fafb7b7 test: pep8 (MarcoFalke) fa32cb2 test: Use MiniWallet in mempool_persist (MarcoFalke) faca688 test: Add MiniWallet get_descriptor function (MarcoFalke) Pull request description: ACKs for top commit: laanwj: Code review ACK faae098 Tree-SHA512: 6124f16ee1f3f416c50dc07aebe8846ff7e2b7c8e5dd84f9517cb5f1df021b9e57ed7c7e17bc099a37c663cd93f6d417c5e0622c0b359956403d53e705eb5549
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 24, 2021
faae098 test: Check other fields are loaded correctly as well (MarcoFalke) fa4db92 test: Remove unused self.connect_nodes (MarcoFalke) fafb7b7 test: pep8 (MarcoFalke) fa32cb2 test: Use MiniWallet in mempool_persist (MarcoFalke) faca688 test: Add MiniWallet get_descriptor function (MarcoFalke) Pull request description: ACKs for top commit: laanwj: Code review ACK faae098 Tree-SHA512: 6124f16ee1f3f416c50dc07aebe8846ff7e2b7c8e5dd84f9517cb5f1df021b9e57ed7c7e17bc099a37c663cd93f6d417c5e0622c0b359956403d53e705eb5549
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.