Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] ci: Test required resources for native Windows task #23217

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] ci: Test required resources for native Windows task #23217

wants to merge 2 commits into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 7, 2021

#23043 (comment):

What is the time required to complete the task with both (qt and vcpkg) caches invalidated after reducing the memory usage?

#23043 (comment):

I'd say there should be no effect, but I didn't test that.

@hebasto hebasto changed the title [DO NOT MERGE] ci: Test required resources for native Windows tasks [DO NOT MERGE] ci: Test required resources for native Windows task Oct 7, 2021
@fanquake fanquake added the Tests label Oct 7, 2021
@hebasto
Copy link
Member Author

hebasto commented Oct 7, 2021

Results:

Screenshot from 2021-10-07 16-11-13

Screenshot from 2021-10-07 16-11-56

Screenshot from 2021-10-07 16-12-45

This was referenced Oct 7, 2021
Merged
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 7, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #23215 (ci: Add vcpkg downloads cache by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced Oct 7, 2021
Merged
Closed
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 15, 2021
Merge bitcoin#23220: ci: Reduce Windows memory for faster scheduling
02ccf10 
146831f ci: Reduce Windows memory for faster scheduling (MarcoFalke)

Pull request description:

  A rebased bitcoin@fac3ae2 from bitcoin#23043.

  The worst scenario (all caches are invalidated) tested in bitcoin#23217.

ACKs for top commit:
  MarcoFalke:
    cr ACK 146831f

Tree-SHA512: 8d5101a7a47139f5358601def3932d199da500ba255740c09a170378a3e6fd9b0ff4ce5a7c0f5f1eb4f26f905f55b47077759b265b67acf9b7b01eec89b7e5da
@hebasto
Copy link
Member Author

hebasto commented Oct 19, 2021

Closing, as #23220 has successfully been merged 🐅

@hebasto hebasto closed this Oct 19, 2021
@hebasto hebasto deleted the 211007-mem branch October 19, 2021 14:53
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @DrahtBot @fanquake