qt: Prefix makefile variables with QT_ #23242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. Use scripted-diff? |
shaavan
reviewed
Oct 9, 2021
There was a problem hiding this comment.
Concept ACK
This PR focuses on improving the consistency and readability of Makefile.qt.include by renaming the variable per their proper function and usage. Since there is a high probability of introducing new QML variables in the future, this is a small but necessary change.
As we are on the matter of variable naming consistency, I want to add something, though. In the Makefile.qt.include on lines 292 and 324. Shouldn’t the variable BITCOIN_RS also be renamed to BITCOIN_QT_RS?
|
I’ll take a look @shaavan, thanks. |
|
No objections, this probably improves the variable naming. Checked that none of the old names remain. Code review ACK e8b6e7c |
hebasto
approved these changes
Oct 13, 2021
promag
force-pushed
the
2021-10-qt-makefile
branch
from
e8b6e7c
to
acf4520
Compare
Improves consistency and readability if future QML variables are added.
-BEGIN VERIFY SCRIPT-
sed -i \
-e 's/RES_ANIMATION/QT_RES_ANIMATION/g' \
-e 's/RES_FONTS/QT_RES_FONTS/g' \
-e 's/RES_ICONS/QT_RES_ICONS/g' \
-e 's/BITCOIN_RC/BITCOIN_QT_RC/g' \
src/Makefile.qt.include
-END VERIFY SCRIPT-
promag
force-pushed
the
2021-10-qt-makefile
branch
from
acf4520
to
eb04bad
Compare
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 14, 2021
hebasto
added a commit
to bitcoin-core/gui-qml
that referenced
this pull request
Oct 19, 2021
Pull request description: Sync with the main repo up to bitcoin-core/gui@ef59692. This sync includes: - bitcoin/bitcoin#23242 ported from #49 - bitcoin/bitcoin#23286 ported from #58 Parent commits: ``` $ git rev-parse 8967f19^@ 8cfb3cb ef59692 ``` ACKs for top commit: jarolrod: ACK 8967f19 Tree-SHA512: c387e638862afe5fd4711d9c1aad36165d04f328612c9b74b35a50b477933e6c6b8cf0674caf3b02e24a22d8598aee7e880baf4c3879c629f71a92af31714548
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves consistency and readability if future QML variables are added.