bitcoin-tx: Require that input amount is provided for witness transactions #23784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theStack
force-pushed
the
bitcoin-tx_check_witness_input_amount
branch
from
02842dc
to
8dc5fa1
Compare
josibake
reviewed
Dec 29, 2021
|
One other suggestion: add a test with a 0 amount as that is a good (edge?) case to have tested. |
…ions Co-authored-by: Sebastian Falbesoner <sebastian.falbesoner@gmail.com>
theStack
force-pushed
the
bitcoin-tx_check_witness_input_amount
branch
from
8dc5fa1
to
8bd34dc
Compare
|
Thanks for the valuable review @josibake! Rebased on master and force-pushed with the following adaptions:
( |
|
ACK 8bd34dc |
|
Needs OP adjusted before merge? |
Thanks, done. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 6, 2022
…d for witness transactions 8bd34dc test: check that bitcoin-tx detects missing input amount for segwit transactions (Sebastian Falbesoner) c337b27 Require that input amount is provided for bitcoin-tx witness transactions (Ben Woosley) Pull request description: This PR picks up the obviously abandoned PR bitcoin#13608 (last activity was three and a half years ago) by rebasing it on master and adding missing tests. Original PR description: "_Applies fix from bitcoin#12458 / bitcoin#13547 to bitcoin-tx._" The private key is the compressed version of the one used in most other util tests (5HpHagT65TZzG1PH3CSu63k8DbpvD8s5ip4nEB3kEsreAnchuDf, corresponds to the scalar value k=1 in big endian), since segwit signing refuses uncompressed keys. The error message from the picked up PR is changed to not include the amount, as showing any value would be just confusing. ACKs for top commit: josibake: ACK bitcoin@8bd34dc Tree-SHA512: 334b418f89527363ad7e3326b4126e86a05fd64876c49a8280de38e64cfac52cb62c4b24b83603dd68b6bcebbe57c64161832edffb1cac7e9c68426f6b6eae1f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up the obviously abandoned PR #13608 (last activity was three and a half years ago) by rebasing it on master and adding missing tests. Original PR description: "Applies fix from #12458 / #13547 to bitcoin-tx."
The private key is the compressed version of the one used in most other util tests (5HpHagT65TZzG1PH3CSu63k8DbpvD8s5ip4nEB3kEsreAnchuDf, corresponds to the scalar value k=1 in big endian), since segwit signing refuses uncompressed keys.
The error message from the picked up PR is changed to not include the amount, as showing any value would be just confusing.