test: Fix rpc_scantxoutset intermittent issue #23858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2021 12:03
Can be reviewed with --word-diff-regex=. --ignore-all-space
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
theStack
approved these changes
Dec 26, 2021
There was a problem hiding this comment.
Code-review ACK fafe4de
Longer term it would be nice to remove the wallet and use MiniWallet here.
Opened a PR #23866, with the PEP8 changes of this PR cherry-picked. It can be seen as an alternative, happy to rebase though if this gets in first (which could make sense considering that it is an obvious immediate fix to an issue and reviewing the other likely takes longer than this one).
|
Going to merge this to fix the CI and to make a bugfix backport easier (if needed) |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 27, 2021
maflcko
pushed a commit
to bitcoin-core/gui
that referenced
this pull request
Dec 27, 2021
…t.py e844115 test: use MiniWallet for rpc_scantxoutset.py (Sebastian Falbesoner) 983ca04 test: introduce `address_to_scriptpubkey` helper (Sebastian Falbesoner) e704d4d test: introduce `getnewdestination` helper for generating various address types (Sebastian Falbesoner) Pull request description: This PR enables one more of the non-wallet functional tests (rpc_scantxoutset.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078 and bitcoin/bitcoin#23858 (comment) more recently. Reviewer's guide: * [commit 1/3] For replacing the getnewaddress/getaddressinfo RPC calls a helper `getnewdestination` is introduced which allows to create addresses with the common address format types ('legacy', 'p2sh-segwit' and 'bech32'), but also additionally returns the corresponding pubkey and output script. * [commit 2/3] In order to send to addresses with MiniWallet, a helper `address_to_scriptpubkey` is introduced. It only supports legacy addresses (Base58Check) so far, which is sufficient for the scantxoutset test. * [commit 3/3] With those helpers, the use of MiniWallet in the test is quite straight-forward. To avoid repeatedly specifying parameters like `from_node` to MiniWallet's `send_to` method, another test-internal helper `sendtodestination` is introduced which supports specifying the destination both as outputscript or as address. ACKs for top commit: w0xlt: reACK [e844115](bitcoin/bitcoin@e844115) Tree-SHA512: e4823dc507019b2b8e479602963c5dddc4c78211e1d934218ee0f0e32c068ab7e44e9793307f549127946364f57d684c4ea1d70f25865ea70d30d4f3855836d0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fail to see how this could have ever worked, since there is nothing that prevents the wallet from spending the coins in the utxo set.
Fixes #23847
Longer term it would be nice to remove the wallet and use MiniWallet here.