WIP: net/p2p:rename command*/Command/* to message*/Message*

[RandyMcMillan]

-BEGIN VERIFY SCRIPT-
SED=$(which gsed)
export SED
echo $SED
export SRC=src
function s { git grep -l "$1" $SRC | xargs $SED -i "s/$1/$2/g"; }
function doit1 {
s 'COMMAND_SIZE' 'MESSAGE_SIZE'
s 'command name' 'message name'
s 'pchCommand' 'pchMessage'
s 'pszCommand' 'pszMessage'
}
function doit2 {
s 'GetCommand' 'GetMessage'
}
export SRC=src && doit1
export SRC=src/net.h && doit1
export SRC=src/net.cpp && doit1
export SRC=src/protocol.h && doit1
export SRC=src/protocol.cpp && doit1
export SRC=src/test/fuzz/protocol.cpp && doit1
export SRC=src/test/fuzz/protocol.cpp && doit2
export SRC=src/test/fuzz/process_messages.cpp && doit1
export SRC=src/test/fuzz/process_messages.cpp && doit2
-END VERIFY SCRIPT-

[RandyMcMillan]

After reviewing PR #24141
It seems appropriate to rename COMMAND_SIZE to MESSAGE_SIZE

MESSAGE_SIZE better suggests the usage and scope of this variable.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #23438 (refactor: Use spans of std::byte in serialize by MarcoFalke)
• #23233 (BIP324: Add encrypted p2p transport {de}serializer by dhruv)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[laanwj]

I do think "Message" is a better fit than "Command" conceptually. A P2P network doesn't have commands.
~0 on renaming it all over the place, though.
Also, maybe something like "MessageType" would be a better name when you're renaming anyway. It'd be clearer that it refers to a field defining what kind of message it is instead of the entire message.

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}