-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove utxo db upgrade code #24236
Remove utxo db upgrade code #24236
Conversation
16e2a31
to
fa96982
Compare
Concept ACK |
1 similar comment
Concept ACK |
fafd3a6
to
faf989d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. Prefer to merge this after the v23 branch-off, unless anything builds on it.
tACK faf989d
In the release notes we could suggest that users who are still on v0.13.1-0.14.x can, as an alternative to reindexing, first upgrade to v22.0.
There is a bunch of stuff that builds on it, but no rush. Assigned 24.0 for now. |
faf989d
to
fa97554
Compare
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
fa97554
to
fa39235
Compare
fa39235
to
fabd801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
any rationale for testing against v0.14.3 versus v0.13.1? or both?
Thanks for the review. 13.x can not be tested by our current test framework, as there were changes in 14.x that were backward compatible, but not forward compatible. See https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.14.0.md#support-for-json-rpc-named-arguments It is possible to adjust the test framework for this to test 13.x, but I don't think this is worth it. The automated test with 14.x should be sufficient. Also, anyone can run a test with 13.x locally for a one-off. |
fabd801
to
fa9112a
Compare
Addressed test nit. Should be trivial to re-ACK with:
|
re-ACK fa9112a |
Code review ACK fa9112a |
It is not possible to upgrade Bitcoin Core pre-segwit (pre-0.13.1) to a recent version without a full IBD from scratch after commit 19a56d1 (released in version 22.0).
Any Bitcoin Core version with the new database format after commit 1088b02 (released in version 0.15), can upgrade to any version that is supported as of today.
This leaves the versions 0.13.1-0.14.x. Even though those versions are unsupported, some users with an existing datadir may want to upgrade to a recent version. However, it seems reasonable to simply ask them to
-reindex
to run a full IBD from scratch. This allows us to remove the utxo db upgrade code.