Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump expat to the latest version #24756

Closed
wants to merge 1 commit into from

Conversation

@laanwj
Copy link
Member

laanwj commented Apr 4, 2022

Expat is a dependency of fontconfig (right?), which is linked dynamically. So as I understand it, we don't actually link it into the binary. If that is the case, bumping its minor version makes no difference at all.

@hebasto
Copy link
Member Author

hebasto commented Apr 4, 2022

Expat is a dependency of fontconfig (right?), which is linked dynamically. So as I understand it, we don't actually link it into the binary. If that is the case, bumping its minor version makes no difference at all.

Correct. I've suggested this change as a part of #22708, where the native_expat package being linked statically.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 5, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@hebasto
Copy link
Member Author

hebasto commented Apr 15, 2022

Expat is a dependency of fontconfig (right?), which is linked dynamically. So as I understand it, we don't actually link it into the binary. If that is the case, bumping its minor version makes no difference at all.

Correct. I've suggested this change as a part of #22708, where the native_expat package being linked statically.

It is no longer the case. See #22708 (comment).

Closing.

@hebasto hebasto closed this Apr 15, 2022
@hebasto hebasto deleted the 220404-expat branch April 15, 2022 10:41
@bitcoin bitcoin locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants