scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

[hebasto]

Working on migration from Autotools to CMake build system, I found that our current code base needs to be adjusted.

CMake allows to

handle the Qt uic code generator automatically

When using this feature, statements like #include "ui_<ui_base>.h" are processed in a special way.

The node/ui_interface.h unintentionally breaks this feature. Of course, it is possible to provide a list of source files to be excluded from AUTOUIC. But, unfortunately, this approach does not work for the qt/sendcoinsdialog.cpp source file, where there are both

bitcoin/src/qt/sendcoinsdialog.cpp

Line 10 in b71d37d

#include <qt/forms/ui_sendcoinsdialog.h>

and

bitcoin/src/qt/sendcoinsdialog.cpp

Line 24 in b71d37d

#include <node/ui_interface.h>

[dongcarl]

Oh! What happens if we do set_property(SOURCE node/ui_interface.h PROPERTY SKIP_AUTOUIC ON)?

[hebasto]

@dongcarl

Oh! What happens if we do set_property(SOURCE node/ui_interface.h PROPERTY SKIP_AUTOUIC ON)?

It does not help:

[ 12%] Automatic MOC and UIC for target bitcoinqt

AutoUic error
-------------
"SRC:/src/qt/sendcoinsdialog.cpp"
includes the uic file "node/ui_interface.h",
but the user interface file "interface.ui"
could not be found in the following directories
  "SRC:/src/qt/node"
  "SRC:/src/qt"
  "SRC:/src/qt/forms"
  "SRC:/src/qt/forms/node"

gmake[3]: *** [src/qt/CMakeFiles/bitcoinqt_autogen.dir/build.make:71: src/qt/CMakeFiles/bitcoinqt_autogen] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:754: src/qt/CMakeFiles/bitcoinqt_autogen.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:734: src/qt/CMakeFiles/bitcoin-qt.dir/rule] Error 2
gmake: *** [Makefile:358: bitcoin-qt] Error 2

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)
• #23443 (p2p: Erlay support signaling by naumenkogs)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[hebasto]

Friendly ping @ryanofsky

[furszy]

Concept ACK

[Sjors]

interface_ui.h is a bit more readable

[hebasto]

Thanks! Updated.

[laanwj]

I don't know, ~0 on this, I dislike the idea of having to rename source files to make the build system happy.

Oh! What happens if we do set_property(SOURCE node/ui_interface.h PROPERTY SKIP_AUTOUIC ON)?

I would prefer a solution like that.

[maflcko]

cr ACK 018d70b

New name is fine and I reviewed the scripted diff.

No opinion on the build system stuff.

[hebasto]

@laanwj

I don't know, ~0 on this, I dislike the idea of having to rename source files to make the build system happy.

Oh! What happens if we do set_property(SOURCE node/ui_interface.h PROPERTY SKIP_AUTOUIC ON)?

I would prefer a solution like that.

You are right. I also prefer some kind of build system switchers. But they do not work for qt/sendcoinsdialog.cpp source file, which should be processed, as it contains #include <qt/forms/ui_sendcoinsdialog.h> , and should be skipped, as it contains #include <node/ui_interface.h>. Looks like it is impossible without renaming.

[Sjors]

We already have build system code that special cases ui_<...>.h files (though afaik only in qt/forms), so the rename is probably a good idea anyway.

[ryanofsky]

Code review ACK 018d70b

[furszy]

Code review ACK 018d70b

Small scripted-diff.