-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: log RPC port on startup #26131
log: log RPC port on startup #26131
Conversation
I just spent a few hours trying to figure out why "18444" wasn't getting me to regtest's RPC server. I'm not the sharpest tool in the shed, but I was maybe understandably confused because "Bound to 127.0.0.1:18445" appears in the logs, which I assumed was the P2P port. This change logs the RPC listening address, which seems like a basic piece of information that shouldn't be buried in debug logs.
ef51b09
to
9d14f27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9d14f27
I agree this is useful information to log
2022-09-20T04:34:30Z Binding RPC on address ::1 port 18443
2022-09-20T04:34:30Z Binding RPC on address 127.0.0.1 port 18443
Wouldn't the solution be to set the log level to INFO? |
ACK 9d14f27 I have also spent time in the past looking for the correct ports, so this makes sense to me. |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Good for merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9d14f27
9d14f27 log: log RPC port on startup (James O'Beirne) Pull request description: I just spent a few hours trying to figure out why "18444" wasn't getting me to regtest's RPC server. I'm not the sharpest tool in the shed, but I was maybe understandably confused because "Bound to 127.0.0.1:18445" appears in the logs, which I assumed was the P2P port. This change logs the RPC listening address by default on startup, which seems like a basic piece of information that shouldn't be buried under `-debug`. ACKs for top commit: dergoegge: ACK 9d14f27 jarolrod: ACK 9d14f27 aureleoules: ACK 9d14f27 Tree-SHA512: 5c86f018c0b8d6264abf878c921afe53033b23ab4cf289276bb1ed28fdf591c9d8871a4baa4098c363cb2aa9a637d2e4e18e56b14dfc7d767ee40757d7ff2e7c
I just spent a few hours trying to figure out why "18444" wasn't getting me to regtest's RPC server. I'm not the sharpest tool in the shed, but I was maybe understandably confused because "Bound to 127.0.0.1:18445" appears in the logs, which I assumed was the P2P port.
This change logs the RPC listening address by default on startup, which seems like a basic piece of information that shouldn't be buried under
-debug
.