Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.x] bump version to v24.0 #26503

Merged
merged 3 commits into from
Nov 17, 2022
Merged

[24.x] bump version to v24.0 #26503

merged 3 commits into from
Nov 17, 2022

Conversation

fanquake
Copy link
Member

Bump version to v24.0.
Regenerate manpages.
Pull in the release notes from the devwiki:

  • I've added the credits section; please comment if a name is missing / needs amending.
  • I've dropped any content-less sections.
  • If there are items that should be in the release notes, and are still missing, please comment.

@0xB10C
Copy link
Contributor

0xB10C commented Nov 15, 2022

@stickies-v RPC diff summary between 24.0 and 23.0 in bitcoin-core/bitcoincore.org#919 shows the following new RPCs.

I've moved the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft#migrating-legacy-wallets-to-descriptor-wallets section to "New RPCs" and added simulaterawtransaction.

@fanquake
Copy link
Member Author

and added simulaterawtransaction.

Included that change here.

I've moved the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft#migrating-legacy-wallets-to-descriptor-wallets section to "New RPCs"

Not sure, as it might be worthwhile having the callout for this in the Wallet section. Thoughts @achow101?

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the steps in doc/release-process.md for "Before every major and minor release" and "Before every major release" were followed (modulo my comment re bips.md).

Left a few suggestions, but generally LGTM.

doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly skimmed through the release notes, and they look good to me. Including and particularly the text on the new mempoolfullrbf option.

@instagibbs
Copy link
Member

LGTM 57170b4

Copy link
Contributor

@mzumsande mzumsande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

doc/release-notes.md Outdated Show resolved Hide resolved
@achow101
Copy link
Member

I've moved the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft#migrating-legacy-wallets-to-descriptor-wallets section to "New RPCs"

Not sure, as it might be worthwhile having the callout for this in the Wallet section. Thoughts @achow101?

Wallet section (or it's own section) would be better than in "New RPCs"

doc/release-notes.md Outdated Show resolved Hide resolved
@harding
Copy link
Contributor

harding commented Nov 15, 2022

FYI, there was an alternative version of the mempoolfullrbf text that was reviewed by multiple people here: https://gist.github.com/harding/f3cd8affb10cea96d352347fed7f4a3a

@achow101
Copy link
Member

ACK 190709e

@petertodd
Copy link
Contributor

ACK release notes

@luke-jr
Copy link
Member

luke-jr commented Nov 15, 2022

@jonatack relates on IRC: "[The backports in #26457] may appear minor, but without them v24 will break user space. For example, the CashApp crypto team informed me that v24 will break their production systems if they upgrade without those patches. I've been proposing to fix these since August before v24 branch-off. If we go forward as-is, it seems to me the v24 release notes ought to warn about the changes (last I looked a few days ago, there was no mention of it)."

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 190709e

doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 16, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Count Reviewers
ACK 1 0xB10C
Stale ACK 3 LarryRuane, achow101, hebasto

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 8810fbd

Copy link
Contributor

@LarryRuane LarryRuane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 53d6040
Nit suggestions

doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
@0xB10C
Copy link
Contributor

0xB10C commented Nov 17, 2022

ACK 0ee1cfe

@fanquake fanquake merged commit dd314fe into bitcoin:24.x Nov 17, 2022
@fanquake fanquake deleted the 24_0_final branch November 17, 2022 11:48
fanquake added a commit to fanquake/bitcoin that referenced this pull request Nov 17, 2022
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Jan 20, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.