-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.x] bump version to v24.0 #26503
[24.x] bump version to v24.0 #26503
Conversation
@stickies-v RPC diff summary between 24.0 and 23.0 in bitcoin-core/bitcoincore.org#919 shows the following new RPCs.
I've moved the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft#migrating-legacy-wallets-to-descriptor-wallets section to "New RPCs" and added |
Included that change here.
Not sure, as it might be worthwhile having the callout for this in the Wallet section. Thoughts @achow101? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the steps in doc/release-process.md
for "Before every major and minor release" and "Before every major release" were followed (modulo my comment re bips.md
).
Left a few suggestions, but generally LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly skimmed through the release notes, and they look good to me. Including and particularly the text on the new mempoolfullrbf
option.
LGTM 57170b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Wallet section (or it's own section) would be better than in "New RPCs" |
FYI, there was an alternative version of the mempoolfullrbf text that was reviewed by multiple people here: https://gist.github.com/harding/f3cd8affb10cea96d352347fed7f4a3a |
ACK 190709e |
ACK release notes |
@jonatack relates on IRC: "[The backports in #26457] may appear minor, but without them v24 will break user space. For example, the CashApp crypto team informed me that v24 will break their production systems if they upgrade without those patches. I've been proposing to fix these since August before v24 branch-off. If we go forward as-is, it seems to me the v24 release notes ought to warn about the changes (last I looked a few days ago, there was no mention of it)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 190709e
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK 8810fbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 53d6040
Nit suggestions
ACK 0ee1cfe |
Bump version to v24.0.
Regenerate manpages.
Pull in the release notes from the devwiki: