Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: drop E275 rule in lint-python.py for flake8 5.0.4, update dependencies #26801

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented Jan 3, 2023

It is helpful to be able to run the python linter locally to review PRs and check local diffs and work. Fix the errors raised by ./test/lint/lint-python.py when run locally with flake8 5.0.4, which enforces rule E275 more strictly than previous versions, by dropping enforcement of that rule from our linter. Also update our python linter CI dependencies. Alternative to #26257.

as flake8 enforces rule E275 more strictly since several months now, causing
a fairly large number of errors to be reported by lint/lint-python.py.
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 3, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@maflcko maflcko changed the title script: drop E275 rule in lint-python.py for flake8 5.0.4, update dependencies test: drop E275 rule in lint-python.py for flake8 5.0.4, update dependencies Jan 3, 2023
@maflcko maflcko removed the Consensus label Jan 3, 2023
@DrahtBot DrahtBot added the Tests label Jan 3, 2023
@jonatack
Copy link
Contributor Author

jonatack commented Jan 3, 2023

Closing as alternative #26257 was merged.

@jonatack jonatack closed this Jan 3, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants